Repository navigation
Pin core v1.36.1: a complex value inside an MCOS object shows as the number it is - #44
Merged
Merged
Conversation
…number it is Core v1.36.1 shows a complex property of an MCOS object (a Simulink.Parameter whose Value is 3+4i or [1+2i 3+4i 5+6i], in a .mat file or a model workspace) as the number, where it showed [object Object]. NaN/Inf parts and integer or single classes are kept, the Property Inspector lays a complex matrix out as a matrix, and the binary and text .sldd writers write complex values that MATLAB reads back as they were. The lock now resolves data-explorer-core to v1.36.1 (21a4ecd). Every lockfile resolution still points at the public registry. The extension's own version is not bumped here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This moves the core pin from v1.36.0 to v1.36.1 (mathworks/data-explorer-core#67, released as v1.36.1).
A complex property of an MCOS object showed
[object Object]. For example, aSimulink.Parameterwhose Value is3+4ior[1+2i 3+4i 5+6i], in a.matfile or a model workspace. It now shows the number, spelled the way the extension spells complex numbers elsewhere. Also in this core release:.slddwriters now write complex values that MATLAB reads back as they were.Only
package.jsonandpackage-lock.jsonchange. The extension's own version is not bumped.Verification
npm run verify: 163 files, 3,106 tests passed.npm run test:integration: 153 passing, 1 pending, the same as Pin core v1.36.0: an MCOS object nested in a struct or cell resolves as its top-level twin #42.npm run check:leak: all 646 lockfile resolutions point at the public registry.3+4iand[1+2i 3+4i 5+6i], with no[object Object]on any node. On core's new complex fixtures,.mat, model-workspace, text.slddand binary.slddagree.