fix: upgrade Furo to 2025.12.19 to fix right panel highlight offset (#7019)#9049
fix: upgrade Furo to 2025.12.19 to fix right panel highlight offset (#7019)#9049rafaumeu wants to merge 2 commits into
Conversation
…st#7072) The file common-esr-support-rst.rst is designed to be included by multiple pages (releases-lifecycle.rst, version-archive.rst) but lacks the :orphan: and :nosearch: metadata. When accessed directly via URL, it displays '<no title>' in the browser tab and appears in site search results. Add :orphan: and :nosearch: directives to prevent it from being indexed or showing up in search, consistent with other included-only files like cloud-supported-integrations.rst and badge files.
…attermost#7019) The fixed notification banner breaks the right sidebar's scrollspy section detection because it doesn't account for sticky elements above the header. Furo PR mattermost#664 (released in 2025.07.19) fixes this by including header.top in the offset calculation. Upgrading from 2024.8.6 to 2025.12.19 includes this fix plus Sphinx 9 support and other improvements.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBumps the ChangesFuro Dependency Upgrade
RST Orphan and Nosearch Directives
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Upgrades Furo theme from 2024.8.6 to 2025.12.19 to fix the right panel (table of contents) highlight offset issue where the active section was highlighted one index previous to the actual current section.
Root Cause
Furo's scrollspy logic for the right sidebar ("On this page") did not account for sticky/fixed elements above the main header (like custom notification banners or headers). This caused the active section detection to be off by one.
Fix
Furo PR #664 (merged in 2024.08.06) fixed this by including in the scroll offset calculation, making the TOC highlight resilient to sticky elements above the header.
Testing
Fixes #7019