Skip to content

Test on PHP 8.6 - #327

Merged
ugexe merged 3 commits into
mainfrom
greg/stf-2474-test-the-php-api-clients-on-php-86
Nov 20, 2026
Merged

ugexe merged 3 commits into
mainfrom
greg/stf-2474-test-the-php-api-clients-on-php-86

Conversation

@oschwald

@oschwald oschwald commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PHP 8.6.0 was released on 19 Nov 2026. This adds PHP 8.6 to the Linux test matrix and to the bundled-build matrix.

The macOS and Windows jobs test the lowest and highest supported PHP versions. Their highest version moves from 8.5 to 8.6.

The bundled-build jobs run in the shivammathur/node image, which has PHP 7.2 to 8.5. For 8.6, setup-php installs a shivammathur/php-builder build, and that installs libmaxminddb-dev. The job then failed its check that no system libmaxminddb is present. A new step removes libmaxminddb-dev before that check.

The AddressSanitizer job now builds PHP 8.6.0 from source instead of 8.5.12.

STF-2474

🤖 Generated with Claude Code

STF-2474

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald requested review from horgh and a balanced review from Copilot November 20, 2026 15:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflows add PHP 8.6 to test matrices, update the AddressSanitizer build to PHP 8.6.0, and conditionally remove libmaxminddb-dev during bundled-build setup.

Changes: PHP 8.6 CI coverage

Layer / File(s) Summary
Update PHP test matrices
.github/workflows/test.yml, .github/workflows/test-bundled.yml
The workflows add PHP 8.6 to their version matrices. The macOS and Windows GMP jobs change from PHP 8.5 to PHP 8.6.
Adjust bundled-build package setup
.github/workflows/test-bundled.yml
The workflow removes libmaxminddb-dev when dpkg reports it installed, before the existing system-library availability check.
Update AddressSanitizer PHP version
.github/workflows/clang-addresssanitizer.yml
The workflow downloads and extracts PHP 8.6.0 instead of PHP 8.5.12.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 05709

This change extends CI coverage to PHP 8.6 and does not alter runtime library behavior. The risk of merging is minimal; the new workflow runs themselves will show whether the PHP 8.6 jobs pass.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Test on PHP 8.6" matches the main change. The PR adds PHP 8.6 to the Linux test and bundled-build matrices, and updates the macOS and Windows jobs to test PHP 8.6. The title is short and sp…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "Test on PHP 8.6" matches the main change. The PR adds PHP 8.6 to the Linux test and bundled-build matrices, and updates the macOS and Windows jobs to test PHP 8.6. The title is short and specific. It omits the secondary changes, such as removing libmaxminddb-dev in the bundled build and running AddressSanitizer on PHP 8.6.0, but the title does not need to cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the PHP queue,
Eight-point-six joins the workflow too.
The bundled build clears one package away,
While sanitizers build anew today.
I nibble greens and hop along,
CI keeps testing all day long.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e6687640-bd8c-4372-9e71-50a321462d69
Commits

Reviewing files that changed from the base of the PR and between 1262154 and 057090b.

Files selected for processing: 2

  • .github/workflows/clang-addresssanitizer.yml
  • .github/workflows/test-bundled.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

oschwald and others added 2 commits November 20, 2026 15:30
The shivammathur/node image has PHP 7.2 to 8.5. For PHP 8.6,
setup-php installs a shivammathur/php-builder build, and that
installs libmaxminddb-dev. The bundled-build check then fails
because a system libmaxminddb is present.

STF-2474

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
STF-2474

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ugexe
ugexe merged commit 33eeaff into main Nov 20, 2026
145 checks passed
@ugexe
ugexe deleted the greg/stf-2474-test-the-php-api-clients-on-php-86 branch November 20, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants