Skip to content

STF-2455: Release 3.8.0 - #307

Merged
ugexe merged 5 commits into
mainfrom
greg/release-3.8.0
Nov 18, 2026
Merged

ugexe merged 5 commits into
mainfrom
greg/release-3.8.0

Conversation

@oschwald

@oschwald oschwald commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Release 3.8.0. This is a minor release under SemVer: it adds new request inputs (phone and email verification) and raises the geoip2/geoip2 floor, with no breaking change. The @final tags are PHPDoc only, so existing subclasses still work.

Commits:

  • Require geoip2/geoip2 3.5.0. GeoIP2-php 3.5.0 requires maxmind-db/reader 1.15.0 and maxmind/web-service-common 0.12.0, so minfraud.phar now bundles them. The 3.7.0 phar bundled maxmind-db/reader 1.13.1, which lacks the decoder limits for crafted databases (GHSA-hj94-g986-h9r7). This repo does not require the reader or web-service-common directly.

  • Mark most classes that nothing extends @final (ENG-5819). 21 classes get the tag. These stay open:

    • Model\Insights, because Model\Factors extends it.
    • Model\IpAddress and Model\RiskScoreReason. With @final, PHPStan reports that their jsonSerialize(): ?array never returns null. Narrowing the return type changes the API, so it waits for the next major version.
    • The abstract classes Model\Address and ServiceClient.

    No class here is extended by GeoIP2-php or web-service-common-php.

  • Update the tools in mise.lock with mise 2026.11.9 (CI's version): box 4.7.0 → 4.7.1, composer 2.10.2 → 2.11.2, hugo 0.164.0 → 0.170.0. phpDocumentor 3.10.0 and lychee 0.24.2 are current. hugo 0.170.1 came out today, but mise's version list does not have it yet. Every tool keeps all seven platforms, and composer keeps its GitHub attestations. mise also dropped the stale ubi:box-project/box and ubi:phpDocumentor/phpDocumentor entries, which mise.toml no longer names.

  • Set the 3.8.0 release date (2026-11-18).

Verified locally:

  • php-cs-fixer, phpcs, PHPStan, composer validate, and PHPUnit (612 tests) pass.
  • PHPStan reports class.extendsFinalByPhpDoc for a probe class that extends each of the 21 tagged classes, and reports nothing for the 3 open ones.
  • The 3.7.0 release phar bundles geoip2 v3.4.0, maxmind-db/reader v1.13.1, and web-service-common v0.11.1.
  • A phar built the way release.sh builds it (composer.phar update --no-dev, box.phar compile, dev-bin/phar-test.php) passes the phar test and bundles geoip2 v3.5.0, maxmind-db/reader v1.15.0, and web-service-common v0.12.0.
  • phpDocumentor 3.10.0 builds the API docs, and mise run build-docs builds the Hugo site with hugo 0.170.0.
  • Every checksum in mise.lock matches the digest that the GitHub API reports for its release asset. This includes the box and hugo entries that mise marks checksum_source = "mise-versions".
  • The release.sh changelog regex parses the new heading (version in group 1, date in group 3).

release.sh adds the VERSION constant, the README install line, the phar, and the docs on gh-pages.

Part of STF-2455.

🤖 Generated with Claude Code

GeoIP2-php 3.5.0 requires maxmind-db/reader 1.15.0 and
web-service-common 0.12.0. Raising the floor makes minfraud.phar bundle
them. The 3.7.0 phar bundled maxmind-db/reader 1.13.1, which lacks the
decoder limits for crafted databases (GHSA-hj94-g986-h9r7).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3bfbb010-f3b5-4e51-9c81-e818b668e838
Commits

Reviewing files that changed from the base of the PR and between e7bc127 and cc13592.

Files ignored due to path filters: 1

  • mise.lock is excluded by !**/*.lock
Files selected for processing: 25

  • CHANGELOG.md
  • README.md
  • composer.json
  • src/MinFraud.php
  • src/MinFraud/Model/BillingAddress.php
  • src/MinFraud/Model/CreditCard.php
  • src/MinFraud/Model/Device.php
  • src/MinFraud/Model/Disposition.php
  • src/MinFraud/Model/Email.php
  • src/MinFraud/Model/EmailDomain.php
  • src/MinFraud/Model/EmailDomainVisit.php
  • src/MinFraud/Model/Factors.php
  • src/MinFraud/Model/GeoIp2Location.php
  • src/MinFraud/Model/IpRiskReason.php
  • src/MinFraud/Model/Issuer.php
  • src/MinFraud/Model/Phone.php
  • src/MinFraud/Model/Reason.php
  • src/MinFraud/Model/Score.php
  • src/MinFraud/Model/ScoreIpAddress.php
  • src/MinFraud/Model/ShippingAddress.php
  • src/MinFraud/Model/Subscores.php
  • src/MinFraud/Model/Warning.php
  • src/MinFraud/ReportTransaction.php
  • src/MinFraud/ServiceClient.php
  • src/MinFraud/Util.php

No actionable comments were generated in the recent review.

Walkthrough

The 3.8.0 changelog adds release details, including input formats, verification inputs, and the ryft processor. The dependency constraint for geoip2/geoip2 changes to ^v3.5.0. Class docblocks add @final annotations.

Changes: 3.8.0 Release Updates

Layer / File(s) Summary
Class final annotations
src/MinFraud.php, src/MinFraud/Model/*, src/MinFraud/ReportTransaction.php, src/MinFraud/Util.php
Class docblocks add @final annotations. The changelog identifies exceptions and describes the planned final-class status and jsonSerialize() return-type constraint.
Release notes and dependency constraint
CHANGELOG.md, composer.json
The changelog records the November 18, 2026 release date and notes on validation, accepted formats, verification inputs, the ryft processor, and the GeoIP2 dependency. The geoip2/geoip2 constraint changes from ^v3.4.0 to ^v3.5.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Suggested reviewers: horgh

Merge Risk: Minimal · previous review e7bc1

This release marks classes @final in documentation only and raises the GeoIP2 minimum version. Runtime behavior does not change. Consumers who subclass these classes may see a documented static-analysis warning, which they can suppress. No merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "STF-2455: Release 3.8.0" names the release and ticket. The changeset is a release preparation: it bumps the geoip2/geoip2 minimum to 3.5.0, adds @final PHPDoc tags to 21 classes, and update…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "STF-2455: Release 3.8.0" names the release and ticket. The changeset is a release preparation: it bumps the geoip2/geoip2 minimum to 3.5.0, adds @final PHPDoc tags to 21 classes, and updates the changelog with the 3.8.0 date. The title identifies the release, but it does not name the main content changes (the @final tags and the dependency floor raise). It is therefore partially related, not fully descriptive. It is not vague and not unrelated, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit read the release notes at dawn,
Then marked the class docs, one by one.
The GeoIP version hopped ahead,
While dates and formats filled the spread.
“3.8.0!” the rabbit cheered, and ran.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: cf5785f4-65f3-4f16-9ece-af4dee61b82d
Commits

Reviewing files that changed from the base of the PR and between 49cc30d and e7bc127.

Files ignored due to path filters: 1

  • mise.lock is excluded by !**/*.lock
Files selected for processing: 23

  • CHANGELOG.md
  • composer.json
  • src/MinFraud.php
  • src/MinFraud/Model/BillingAddress.php
  • src/MinFraud/Model/CreditCard.php
  • src/MinFraud/Model/Device.php
  • src/MinFraud/Model/Disposition.php
  • src/MinFraud/Model/Email.php
  • src/MinFraud/Model/EmailDomain.php
  • src/MinFraud/Model/EmailDomainVisit.php
  • src/MinFraud/Model/Factors.php
  • src/MinFraud/Model/GeoIp2Location.php
  • src/MinFraud/Model/IpRiskReason.php
  • src/MinFraud/Model/Issuer.php
  • src/MinFraud/Model/Phone.php
  • src/MinFraud/Model/Reason.php
  • src/MinFraud/Model/Score.php
  • src/MinFraud/Model/ScoreIpAddress.php
  • src/MinFraud/Model/ShippingAddress.php
  • src/MinFraud/Model/Subscores.php
  • src/MinFraud/Model/Warning.php
  • src/MinFraud/ReportTransaction.php
  • src/MinFraud/Util.php

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

oschwald and others added 3 commits November 17, 2026 23:58
The classes become final in the next major version (ENG-5819). The tag
lets PHPStan and other analyzers warn users who extend them now.

Insights stays open because Factors extends it. IpAddress and
RiskScoreReason stay open because PHPStan then reports that their
jsonSerialize() never returns null. Narrowing the ?array return type
would break a subclass. No other MaxMind library extends a class here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upgrade box 4.7.0 to 4.7.1, composer 2.10.2 to 2.11.2, and hugo
0.164.0 to 0.170.0. phpDocumentor 3.10.0 and lychee 0.24.2 are the
latest releases. Every tool keeps all seven platforms, and composer
keeps its GitHub attestations.

mise lock also drops the stale ubi:box-project/box and
ubi:phpDocumentor/phpDocumentor entries. mise.toml now names these
tools with the github: backend, so nothing uses the ubi: entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 00:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ugexe
ugexe merged commit 82014cd into main Nov 18, 2026
56 checks passed
@ugexe
ugexe deleted the greg/release-3.8.0 branch November 18, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants