Repository navigation
STF-2455: Release 3.8.0 - #307
Conversation
GeoIP2-php 3.5.0 requires maxmind-db/reader 1.15.0 and web-service-common 0.12.0. Raising the floor makes minfraud.phar bundle them. The 3.7.0 phar bundled maxmind-db/reader 1.13.1, which lacks the decoder limits for crafted databases (GHSA-hj94-g986-h9r7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The classes become final in the next major version (ENG-5819). The tag lets PHPStan and other analyzers warn users who extend them now. Insights stays open because Factors extends it. IpAddress and RiskScoreReason stay open because PHPStan then reports that their jsonSerialize() never returns null. Narrowing the ?array return type would break a subclass. No other MaxMind library extends a class here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upgrade box 4.7.0 to 4.7.1, composer 2.10.2 to 2.11.2, and hugo 0.164.0 to 0.170.0. phpDocumentor 3.10.0 and lychee 0.24.2 are the latest releases. Every tool keeps all seven platforms, and composer keeps its GitHub attestations. mise lock also drops the stale ubi:box-project/box and ubi:phpDocumentor/phpDocumentor entries. mise.toml now names these tools with the github: backend, so nothing uses the ubi: entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e7bc127 to
e044725
Compare
Release 3.8.0. This is a minor release under SemVer: it adds new request inputs (phone and email verification) and raises the
geoip2/geoip2floor, with no breaking change. The@finaltags are PHPDoc only, so existing subclasses still work.Commits:
Require geoip2/geoip2 3.5.0. GeoIP2-php 3.5.0 requires
maxmind-db/reader1.15.0 andmaxmind/web-service-common0.12.0, sominfraud.pharnow bundles them. The 3.7.0 phar bundledmaxmind-db/reader1.13.1, which lacks the decoder limits for crafted databases (GHSA-hj94-g986-h9r7). This repo does not require the reader or web-service-common directly.Mark most classes that nothing extends
@final(ENG-5819). 21 classes get the tag. These stay open:Model\Insights, becauseModel\Factorsextends it.Model\IpAddressandModel\RiskScoreReason. With@final, PHPStan reports that theirjsonSerialize(): ?arraynever returnsnull. Narrowing the return type changes the API, so it waits for the next major version.Model\AddressandServiceClient.No class here is extended by GeoIP2-php or web-service-common-php.
Update the tools in
mise.lockwith mise 2026.11.9 (CI's version): box 4.7.0 → 4.7.1, composer 2.10.2 → 2.11.2, hugo 0.164.0 → 0.170.0. phpDocumentor 3.10.0 and lychee 0.24.2 are current. hugo 0.170.1 came out today, but mise's version list does not have it yet. Every tool keeps all seven platforms, and composer keeps its GitHub attestations. mise also dropped the staleubi:box-project/boxandubi:phpDocumentor/phpDocumentorentries, whichmise.tomlno longer names.Set the 3.8.0 release date (2026-11-18).
Verified locally:
composer validate, and PHPUnit (612 tests) pass.class.extendsFinalByPhpDocfor a probe class that extends each of the 21 tagged classes, and reports nothing for the 3 open ones.release.shbuilds it (composer.phar update --no-dev,box.phar compile,dev-bin/phar-test.php) passes the phar test and bundles geoip2 v3.5.0, maxmind-db/reader v1.15.0, and web-service-common v0.12.0.mise run build-docsbuilds the Hugo site with hugo 0.170.0.mise.lockmatches thedigestthat the GitHub API reports for its release asset. This includes the box and hugo entries that mise markschecksum_source = "mise-versions".release.shchangelog regex parses the new heading (version in group 1, date in group 3).release.shadds theVERSIONconstant, the README install line, the phar, and the docs on gh-pages.Part of STF-2455.
🤖 Generated with Claude Code