Repin the C library, which now carries a caller's redirection into a spawn - #9
Merged
Merged
Conversation
…spawn openkal-musl 0.6.0 answers three defects reported as openkal-linux#13, and two of them are reachable from a program built above this runtime without that program doing anything unusual. A caller that redirects a standard stream and then starts a program --- with posix_spawn, with system, or with fork and execve --- used to have the started program write to the stream the CALLER had been started with. And abort did not end the program: musl's raise is tkill, the port had no case for it, and abort fell through to musl's own a_crash(), so every uncaught C++ exception over this runtime reported a segmentation fault rather than SIGABRT. The second is this runtime's business directly: libc++abi's terminate handler ends in abort. Nothing in this package changes. 0.3.0 -> 0.3.1 records which C library a consumer resolving this version is handed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mcpplibs/openkal-musl#17
and must not merge before openkal-musl 0.6.0 is in the index.
openkal-musl 0.6.0 answers three defects reported as
openkal-linux#13, and two
of them are reachable from a program built above this runtime without that
program doing anything unusual:
posix_spawn, withsystem, or withforkandexecve— had the startedprogram write to the stream the caller had been started with;
abortdid not end the program. musl'sraiseistkill, the port hadno case for it, and
abortfell through to musl's owna_crash()—hltonx86_64. So every uncaught C++ exception over this runtime reported a
segmentation fault rather than SIGABRT, which is this package's business
directly: libc++abi's terminate handler ends in
abort.Nothing in this package changes.
0.3.0→0.3.1records which C library aconsumer resolving this version is handed.
⭐ This run validates the pair before either is released.
tools/branch-graph.shprefers a branch of the same name in each repository ofthe ecosystem, and openkal-musl has one — so what is built here is that pull
request's working tree rather than a version that is not yet in the index.