The closure removes the index directory rather than trusting an update - #16
Merged
Conversation
⚠️ ⚠️ `xlings update' reports success without having refreshed anything, and this script is the one place where that matters most: its whole purpose is to read what was just published, and it cannot begin by reading what was published last time. Measured three times in one day, in three shapes --- an artifact pointer served from a cache, `xlings update' exiting zero while the index directory still held the previous artifact, and a registry reporting the current hash while holding older content. The second is the one that bites here, and deleting the refresh MARKER does not help: `update' re-derives it from the directory that is already there and writes the same hash back. ⇒ The directory is removed. "The index looked fresh" and "the index was fresh" are indistinguishable in every output either produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/sandbox-closure.shis the only thing in this ecosystem that resolves a published package — every workflow substitutes working trees by design. Its whole purpose is to read what was just published, and it began by runningxlings updateand trusting it.xlings updateexiting zero while the index directory still held the previous artifact; and a registry reporting the current hash while holding older content.The second is the one that bites here, and deleting the refresh marker does not help —
updatere-derives it from the directory that is already there and writes the same hash back. Only removing the directory forces a fetch."The index looked fresh" and "the index was fresh" are indistinguishable in every output either produces, which is why this is a change to the script rather than a note in it.