Repository navigation
feat(setup-pstack): pin the trail reviewer and show its step - #295
Conversation
The trail reviewer steps off the work model by rule 7, and a Codex user who wrote sol got astra with no sign of it at setup. Setup now prints the stepped reviewer beside the written one, the step note names the roles that allow the target, and `trail reviewer step: off` keeps the written model and effort on a match, labeled same-model. The rules now say a stepped reviewer's effort follows the work effort.
|
Verdict: FAIL Round 1, full swarm at the code-ready head: gates, live, regression against trunk (swarm workers, sonnet@high) and two audit lanes (trail reviewer, opus@xhigh, resolved with
Sent back to the owner:
Follow-up: #296 (setup preview with |
…its edges The swarm, orchestrate, models-config, roles, and promise-ledger text said the trail reviewer always moves off the work model when the config allows another. Each now says so only while `trail reviewer step` is not `off`, and the ledger claims and quote change with the prose. New tests cover a pinned inherit-parent reviewer staying unlabeled and the pin keeping the arm's earlier notes. The section test now asserts lint output and the resolved step instead of parser storage.
|
Verdict: PASS+NOTES Round 2, single independent verifier (trail reviewer, opus@xhigh, cross-model to the sonnet@high owner). The diff since round 1 is a fix: 7 files, +54/-13, no resolver code.
Note: the PR body still cites 174 tests and fee15bd and its Scope line omits the swarm, orchestrate, roles and ledger prose; the owner will refresh it (no head change). |
Why
Closes #294. On Codex,
trail reviewer: gpt-6.1-sol@xhighran asgpt-6-astra@highwhenever the work ran on sol, because one other role allows astra. Setup never said so, and the user could not turn the step off.What changed
trail reviewer step: offpins the reviewer. A pinned reviewer that matches the work model keeps its written model and effort and reports"step": "same-model". A pin never labels aninherit-parentreviewersame-model, and it keeps the arm's earlier notes.skills/swarm/SKILL.md,skills/poteto-mode/playbooks/orchestrate.md,skills/pstack-harness/references/roles.md, the models-config Grammar bullet, and thePORTING.mdkeep-list. The matching promise-ledger claims and quote (evals/promises/ledger.json) and the oracle evidence string (evals/promises/oracles.py) change in the same commit.Scope
Covers the resolver, the lint, setup prose, the prose sites above with their promise-ledger entries, and tests. Unpinned stepping and its effort rule stay as PR 150 set them.
docs/guideis unchanged, because the guide promise ledger needs a checked promise for every new guide sentence. The setup preview forinherit-parentorautowork roles is filed as #296 and not touched here.Tradeoffs
A setting line beats a marker on the reviewer entry. It fits the
role: entrygrammar and the layer order, and it leaves the (model, effort) tuples that the role contract and tests read alone. The note lists roles only when one to three allow the target, because a long list does not say which line to change.Blast Radius
A step note now carries a role suffix, so a consumer that matches the exact note text changes (one orch recovery test updated). Configs without the new line resolve as before.
Verification
test_check_models_configruns 203 tests, all OK. Round 2 added tests for the pinnedinherit-parentreviewer, the kept notes, and the lint accepting the setting; each fails against a mutant of the resolver or lint.gpt-6.1-sol@high, the reviewer wasgpt-6-astra@highbefore. It is the same arm with(allowed by arena cross-judge pool)now. Withtrail reviewer: gpt-6.1-sol@highandtrail reviewer step: offit resolves togpt-6.1-sol@high,same-model.tools/gate-check.sh lintpasses 9/9 andbun testpasses 542. The test tier fails only on host-bound tests this diff does not touch (anrgpath from the ChatGPT app). The no-mistakes run passed review, test, document, lint, and CI.✅ Low: The resolver change is small and does what the intent asks: the pin follows layer order, the lint validates the setting, the roles that allow the stepped tier are counted by tier, and setting lines are excluded from ROLES and from _written_tiers. Tests run the CLI and the parser and check what they output; the only open item is a minor wording gap in the setup preview.
Updates from git push no-mistakes