Repository navigation
chore: move source-control settings to docs/conventions/source-control.yaml - #521
Conversation
…l.yaml The source-control plugin now reads its team settings from docs/conventions/source-control.yaml (ADR 0064) and will stop reading .claude/source-control.md. Every key and value the legacy file set moves to the YAML unchanged, and the legacy file is deleted. Refs: melodic-software/claude-code-plugins#12286 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings. critical-findings: 0 The PR moves the source-control plugin's team-layer settings from
The I did not check whether the plugin reads the new path. If it doesn't, it falls back to its own defaults. That is a functional concern, not an exploitable path in this diff, and I could not read the upstream resolution code from here. The repository has no CODEOWNERS file, so the move does not change any ownership coverage. Nothing in the diff touches a trusted path, an Actions workflow, a token scope, or a plugin manifest. |
|
claude-review reviewed No findings. I reviewed the full diff, which moves the source-control settings from
|
Refs: melodic-software/claude-code-plugins#12286
Summary
The source-control plugin reads its team settings from
docs/conventions/source-control.yaml(claude-code-plugins ADR 0064) and will stop reading.claude/source-control.mdonce claude-code-plugins#9737 lands. Without this move, this repository loses its babysit loop-lane policy (stop mode, tier, merge rung, grace window) and its PR-body section list.Fix
docs/conventions/source-control.yamlwith every key the legacy file set, values unchanged..claude/source-control.md.git grep source-control.mdfinds nothing), and no CODEOWNERS entry covers.claude/, so no ownership entry moves. The legacy file's notes move into the YAML as comments.Verification
Value parity, from a script that parses every H2 of the legacy file and every key of the YAML:
Legacy
.claude/source-control.mdatorigin/mainvsdocs/conventions/source-control.yamlatHEAD:babysit_loop_stop_modestandingstandingbabysit_loop_tierworkerworkerbabysit_loop_mergec3-autonomousc3-autonomousbabysit_loop_grace_window_minutes3030pr_body_required_sections[Summary, Fix, Verification, Related][Summary, Fix, Verification, Related]5 legacy keys, 5 YAML keys, 0 not MATCH
plugins/source-control/lib/convention-key.sh layerprintsyamlfor every key, andvalue/listprint the values in the table below. Commit-subject enforcement is unchanged:lib/resolve-convention-pattern.shresolves it from the same file onmainand on this branch.babysit_repo_config.py loop-keyson this repository's default branch before this PR printed the same fourbabysit_loop_*values from.claude/source-control.md (legacy),adopted: true. The post-merge rerun is recorded on claude-code-plugins#12286.check-jsonschema==0.39.0againstplugins/source-control/schemas/source-control.schema.json: ok.Related
🤖 Generated with Claude Code