Skip to content

feat(corrections): absorb retro codify and /review:audit-enforceability into /corrections:codify and remove them #11121

Closed
2 of 2 issues completed

Description

@kyle-sexton

Refs: #7573

Agent Brief

Type: Feature
Summary: /corrections:codify absorbs retro's codify mode and /review:audit-enforceability; both are removed and every reference moves to codify. This is the parent's absorb-and-remove slice.

Current behavior:

  • plugins/corrections/skills/codify/SKILL.md "Boundary" says: "It does not run the retro codify mode, /review:audit-enforceability or style; those keep their own counters until a later slice absorbs them." It also says it does not read review comments from pull requests, and its ## Next routes finding-shaped checks to /review:audit-enforceability.
  • plugins/review/skills/audit-enforceability/ still exists. It maps each finding in a review findings file to the cheapest deterministic check.
  • plugins/session-flow/skills/retro/ still has a codify [reviews] mode (context/codify.md, scripts/fetch-review-comments.sh) that mines merged PR review comments.
  • rg -n 'review:audit-enforceability|retro codify' plugins docs --glob '!**/CHANGELOG.md' --glob '!.changes/**' prints about 140 lines across about 60 files on main.

Desired behavior:

  • Codify takes the two inputs it lacks, so the removals lose nothing: a review findings file (what audit-enforceability reads), and PR review comments as a counting source, including the author's own after merge (what retro codify reviews reads).
  • plugins/review/skills/audit-enforceability/ and retro's codify mode are removed, with their probes, evals, schema keys, config entries and README rows.
  • Every reference moves to /corrections:codify. In docs/upstream/ records and in corrections' own files, reword the reference to the current name rather than deleting the record.

Done when

  • rg -n 'review:audit-enforceability|retro codify' plugins docs --glob '!**/CHANGELOG.md' --glob '!.changes/**' prints nothing.
  • plugins/review/skills/audit-enforceability/ does not exist, and retro's argument hint has no codify mode.
  • Codify has eval cases for a findings-file input and a PR-review-comment source, and each removed skill's or mode's eval cases are ported to codify with before/after results in the PR, showing no loss.
  • bash plugins/skill-quality/scripts/check-skill.sh --require-evals plugins/corrections/skills exits 0, and so does check-skill.sh for plugins/review/skills and plugins/session-flow/skills.
  • scripts/check-changelog-fragments.sh passes with fragments for corrections, review and session-flow.

Out of scope:

  • audit-sessions style (also absorbed per the parent): a separate slice.
  • Chat and meeting sources (wait for communication).

Activity

  1. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.
    on Oct 30, 2026
  2. github-actions commented on Oct 30, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: structural
    Basis: automated intake triage; the lanes App applied this class.

    Size: Large
    Complexity: Medium
    Uncertainty: Knowable
    Flags: none
    Blocked by: none

    Understood: extend /corrections:codify to take a review findings file and PR review comments (including the author's own after merge) as inputs. Then remove review's audit-enforceability skill and retro's codify mode, and repoint all roughly 60 files of references to codify. The done-when list is concrete and checkable, with a grep, skill-check scripts, ported eval cases and changelog fragments. No missing information. I found no open duplicate. The change touches three plugins and about 60 files, so a maintainer may want to split it into per-plugin PRs.

    Automated triage, applied by the lanes App.

  3. melodic-automation-lanes commented on Oct 30, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: sub-issue #11129 is open.

  4. melodic-automation-lanes commented on Oct 30, 2026

    @melodic-automation-lanes
    Contributor

    Split at intake (owner Q93). This issue is Size Large, so its done-when is split into 2 sub-issues, each holding its task-list lines as written.

    Automated split by the lanes App. Admission waits on this issue while a sub-issue is open; work-unblock closes it as completed once every sub-issue is closed by a merge or a listed human.

  5. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    Every sub-issue of this split is closed as completed by a listed human or a merge (#11128, #11129), so the lanes App closes it as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.

    Fields

    No fields configured for Feature.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions