Skip to content

refactor(code-metrics): audit router wave 5 of 5 (suppressions, last leaf) #12623

Closed as not planned

Description

@kyle-sexton

Refs #12491

Blocked by #12622.

Outcome

Wave 5 of 5, the last, in the #12491 sized wave plan. It moves audit-suppressions into the code-metrics:audit router: the body becomes actions/suppressions.md and the scripts go under scripts/. It also repoints the four plugin-level eval cases under plugins/code-metrics/evals/audit-suppressions-*, and it removes the last audit-* name with no alias.

  • Measured: 227,966 bytes of git diff --no-renames at b92833d99a, after waves 1 to 4.
  • scripts/shared-copies.txt:473 registers suppression-scan.py as a shared copy: update its path, then run scripts/sync-shared-copies.sh.
  • The detector rule ids code-metrics/audit-suppressions/rule-* keep their value (docs/contracts/detector-findings/README.md:261-262).

Done when

  • before.json is captured on the pre-move tree from the existing four cases.
  • /evals:plugin-eval --baseline before.json --margin 5 passes at non-inferiority.
  • git diff --no-renames origin/main of the PR is under 262144 bytes.
  • ls -d plugins/code-metrics/skills/audit-* 2>/dev/null | wc -l is 0.
  • scripts/validate-plugins.sh passes, and a merge probe is posted per D82/Q186.
  • /code-metrics:audit- appears nowhere outside changelogs.

Related

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  2. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: structural
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: #12622

    Understood: this is wave 5 of 5 of the #12491 plan. It moves audit-suppressions into the code-metrics:audit router (body to actions/suppressions.md, scripts under scripts/). It also repoints the four plugin-level eval cases, updates the shared-copy registration, and removes the last audit-* skill name. The done-when list is exact. Some items need an eval run or a merge probe, which the issue lane or a maintainer handles. The issue says it is blocked by the wave 4 issue, #12622, which is still open. I found no duplicates.

    Automated triage, applied by the lanes App.

  3. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.
    on Nov 3, 2026
  5. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane yet: blocker #12622 is not closed by a listed human or a merge; blocker #12491 is not closed by a listed human or a merge.

  6. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Closed not planned: the owner re-scoped #12491 to option 3 (keep the leaves, distinct trimmed descriptions) and dropped the router merge and its waves: #12491 (comment). The remaining work is #12491 itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.

    Type

    Fields

    Work status

    ready

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions