Skip to content

fix(source-control): write the Siblings line when an issue has merged Refs pull requests #13068

New issue
New issue
Closed
Bug
#13078
Closed
fix(source-control): write the Siblings line when an issue has merged Refs pull requests#13068
Bug
#13078
Assignees
kyle-sexton
Labels
priority: mediumReal value, no hard deadline; normal backlog flow.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

Description

@kyle-sexton
kyle-sexton
opened on Nov 4, 2026

No related issue: found when pr-verify failed PR #13058 for a missing Siblings: line.

Problem

When an issue is delivered by several pull requests, the last one closes it and must name the earlier ones on a Siblings: #<a>, #<b> line (docs/conventions/pr-pipeline/README.md, the pr-verify section, owner decision on #12965). /source-control:pull-request create (plugins/source-control/skills/pull-request/reference/create.md §2.4.0-§2.4.1) writes the Closes #N line but never looks for merged pull requests that carry Refs: #N, so it never writes Siblings:. PR #13058 closed #12918 after PR #12974 had merged with Refs: #12918. pr-verify judged the whole issue against the diff and failed it (fail note on 2026-11-04T03:05Z); adding Siblings: #12974 by hand cleared it. Each such pull request loses one verifier round.

Fix

In create's §2.4.0, when CLOSES_LINE closes issue N, list merged pull requests in this repository whose body has a Refs: #N line and that close no issue (up to 10), and write Siblings: #<a>, #<b> directly below the closing line. Leave the credit checks to resolve-pr, which already applies them.

Acceptance criteria

  • create on a branch that closes an issue with a merged Refs: pull request writes a first-column Siblings: line naming it.
  • With no such pull request, no Siblings: line is written.
  • A test covers both cases and fails without the change.

Related

Activity

  1. kyle-sexton
    added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 4, 2026

  2. github-actions commented on Nov 4, 2026

    @github-actions
    github-actionsBot
    on Nov 4, 2026 – with GitHub Actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none

    Understood: /source-control:pull-request create writes Closes #N but never looks up merged pull requests carrying Refs: #N, so it never writes the Siblings: line. pr-verify then fails the closing PR (seen on #13058, after #12974 merged with Refs: #12918). The fix is in create's §2.4.0. It lists the merged Refs-only PRs and writes Siblings: under the closing line. The acceptance criteria are exact and include a test for both cases. I found no duplicate among the open issues.

    Automated triage, applied by the lanes App.

  3. github-actions
    added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 4, 2026
  4. github-actions
    added the
    Bug
    issue type on Nov 4, 2026
  5. melodic-automation-lanes
    added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Nov 4, 2026
  6. melodic-automation-lanes
    set
    Work status
    to
    ready
    on Nov 4, 2026
  7. melodic-automation-lanes
    added
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 4, 2026
  8. melodic-automation-lanes
    changed
    Work status
    to
    agent-ready
    on Nov 4, 2026

  9. github-actions commented on Nov 4, 2026

    @github-actions
    github-actionsBot
    on Nov 4, 2026 – with GitHub Actions
    Contributor
    No description provided.

  10. github-actions commented on Nov 4, 2026

    @github-actions
    github-actionsBot
    on Nov 4, 2026 – with GitHub Actions
    Contributor
    No description provided.

  11. github-actions commented on Nov 4, 2026

    @github-actions
    github-actionsBot
    on Nov 4, 2026 – with GitHub Actions
    Contributor
    No description provided.
  12. kyle-sexton
    closed this as completedin #13078on Nov 4, 2026
  13. melodic-automation-lanes
    removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 4, 2026
  14. kyle-sexton
    self-assigned this
    on Nov 4, 2026

  15. kyle-sexton commented on Nov 4, 2026

    @kyle-sexton
    kyle-sexton
    on Nov 4, 2026
    MemberAuthor
    No description provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: mediumReal value, no hard deadline; normal backlog flow.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

Type

Bug

Fields

Work status

agent-ready

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions