Skip to content

feat(source-control): commit the legacy FAILs file to turn on FAIL index mode #12558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 4 commits into from
Nov 3, 2026
Merged

feat(source-control): commit the legacy FAILs file to turn on FAIL index mode #12558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d742a4
feat(source-control): commit the legacy FAILs file to turn on FAIL in…
kyle-sexton Nov 2, 2026
d9afceb
fix(source-control): exempt the legacy FAILs file on the typos step, …
kyle-sexton Nov 3, 2026
8789c4d
Merge remote-tracking branch 'origin/main' into data/verify-legacy-fa…
kyle-sexton Nov 3, 2026
9972995
Merge remote-tracking branch 'origin/main' into data/verify-legacy-fa…
kyle-sexton Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/source-control/data-verify-legacy-fails-file-1f4a8786.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Changed

- `babysit-prs`: the pr-verify verdict reader now runs in FAIL index mode. It reads a pull request's FAILs from the FAIL index plus the committed `verify-legacy-fails.json`, which lists the 550 FAILs uploaded before the index existed, instead of paging the whole artifact listing on every judgment.
3 changes: 2 additions & 1 deletion .github/workflows/pr-require-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,8 @@ jobs:
# calibration cases are code copied verbatim from other repositories'
# histories, so a correction would change what the judge is measured on;
# the developer-experience labeled samples are judge inputs for the same reason.
exclude: plugins/*/skills/*/vendor/** plugins/*/tools/*/vendor/** plugins/testing/skills/audit/evals/judge-calibration/cases/** plugins/developer-experience/evals/sources/labels/**
# verify-legacy-fails.json is generated verdict data (SHAs, branch names).
exclude: plugins/*/skills/*/vendor/** plugins/*/tools/*/vendor/** plugins/testing/skills/audit/evals/judge-calibration/cases/** plugins/developer-experience/evals/sources/labels/** plugins/source-control/skills/babysit-prs/scripts/verify-legacy-fails.json

# Every run scans only history the commit under test can reach, so a
# finding on another branch cannot fail it (#3599); each branch is scanned
Expand Down
Loading
Loading