Repository navigation
feat(review): add a codex fanout_diversity value that puts the panel on the Codex reviewer #12636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
melodic-automation-lanes
wants to merge
2
commits into
main
from
work-resolve-issue/issue-12504-41563977457-1
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/review/work-resolve-issue-issue-12504-41563977457-1-35444ae0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Added | ||
|
|
||
| - `fanout_diversity` takes a third value, `codex`. Under it, `/review:fanout run-everything` runs the `lens` roster and uses the Codex reviewer, through `skills/fanout/scripts/codex-review.sh`, as the model-diversity panel in place of `model` mode's same-vendor model tiers. The surfaces it runs are the ones `lens` runs; it adds a `panel:` line, `panel: codex ran`, or `panel: codex skipped (<reason>)` when Codex is not installed, enabled or logged in, and the lens sweep still runs. The default stays `lens`. Set `codex` through the plugin option or `docs/conventions/review.yaml` (#12504). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifest userConfig.fanout_diversity.options: flag, a third accepted value
codexis added to an existing userConfig keyThe
optionslist is not in the inert manifest set, so the default-deny rule flags it. I read the code and skill text that use this key, and the change widens nothing:fanout_diversityonly chooses how/review:fanout run-everythingspreads its leaf reviews. It does not gate, cap, confirm or charge for anything."default": "lens"(line 47) is the same as before, so installed users who never set the key behave the same after they update.codex, the sweep still launches withargs.diversityset tolens(skills/fanout/context/run-everything-mode.md:16-17). The Codex panel is step 3's twocodex-review.shruns, and step 3 already makes those runs in every mode (run-everything-mode.md:11). The new value only adds apanel:report line.docs/conventions/review.yamlstill cannot set its own reviewers. That layer is skipped for such a change set (reference/config.md, unchanged rule).severity: IMPORTANT
claude-lane: claude-security-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence:
plugins/review/.claude-plugin/plugin.json:47,plugins/review/.claude-plugin/plugin.json:51,plugins/review/skills/fanout/context/run-everything-mode.md:11,plugins/review/skills/fanout/context/run-everything-mode.md:16,plugins/review/skills/fanout/context/run-everything-mode.md:17,plugins/review/skills/fanout/SKILL.md:64