Repository navigation
fix(discovery): give the research Effort-ceiling sentence headroom in the re-attach slice #12647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
melodic-automation-lanes
wants to merge
2
commits into
main
from
work-resolve-issue/issue-12631-41571316834-1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/discovery/work-resolve-issue-issue-12631-41571316834-1-f83c6418.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: patch | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - `/discovery:research`: the sentence saying the Effort row caps discipline 8 now sits in the Disciplines intro, ahead of the numbered list, instead of opening "Effort, source breadth". It now ends at about byte 15,200, well inside the first 20,000 bytes that compaction re-attaches. The paragraph on grading each sub-slice of an N-topic fan-out moved under "The deep tier", and acceptance gate step 2 points to it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advisory: no test pins the closing issue's headroom criterion.
#12631's done-when says: "Done when the sentence has at least 2000 bytes of headroom, or the window no longer applies to it, and
contract.test.shpasses."The move meets this. The author says the sentence now ends at about byte 15,225; I did not measure it. But the only check is
assert_in_sliceatplugins/discovery/scripts/contract.test.sh:387-388, and it fails only after byte 20,000. Edits above this line can wear the headroom back down to 1 byte, which is the state #12631 was filed for, and nothing would fail until it is gone.To fix it, add a headroom check for this phrase, for example one that fails when the sentence ends after byte 18,000. Or record in the test's comment that the headroom is not enforced, so the next person who trims for the window knows it is unenforced.
claude-lane: claude-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence:
plugins/discovery/scripts/contract.test.sh:358,plugins/discovery/scripts/contract.test.sh:387