Repository navigation
perf(source-control): move the commit skill's rationale out of its hub - #12704
Conversation
The /source-control:commit SKILL.md body drops from 28,967 to 25,098 bytes (frontmatter stripped). Explanatory prose moves verbatim to reference files read on demand: the repository-context probe reasons to reference/config-probes.md, the changelog-fragment detail to reference/changelog-fragments.md, the type-set sources, mod note, key spelling and recorded deviation to reference/design-rationale.md, and the three native-surface descriptions to reference/native-commit.md. Every command, table and gate stays in the hub. Refs: #12666 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcuponMacsFYBfNzLKb3ws
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d80bd5dcb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-security-review reviewed Security review: PR #12704, incremental since
|
|
claude-review reviewed Code review (incremental): PR #12704, changes since
|
Keep in the hub the step-7 rule that a plugin the fragment list does not name still needs its hand version bump and CHANGELOG entry. Replace the restated mod-hook and GitHub trailer behavior in design-rationale.md with pointer, as-of and recheck records. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcuponMacsFYBfNzLKb3ws
|
Reply to the claude-review finding on
Fixed in 9a365b4. Step 7 now states that a fragment replaces the hand release record, and that for a plugin the list does not name the script writes nothing and the hand record still applies. |
commit-hook-rejection-no-bypass and commit-never-stage-everything never fired the commit skill (0 of 8 runs each), and commit-no-push-no-pr missed on main's copy: the prompts led with a raw git instruction, so the model ran git itself or routed to the pull-request skill. Each prompt now opens with the commit request; the first two name the source-control:commit skill, since a plain request still ran git directly. The --no-verify, git add -A, and push-and-PR asks the graders judge are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcuponMacsFYBfNzLKb3ws
commit-trailer-model-from-session run 2 on main's skill body committed with a heredoc and never called Skill, so the skill-fired grader missed and the before arm read as invalid. The prompt now asks for the commit with the source-control:commit skill, the same way the other three commit cases do. The Fable 5.1 trailer string the graders judge is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #12666
Summary
The
/source-control:commithub loaded explanatory prose on every invocation that a commit rarely needs. This PR moves that prose word for word into reference files read on demand, and keeps every command, table and gate in the hub. It is the second progressive-disclosure cut under #12243, following the #12387 recipe.Fix
reference/config-probes.md,reference/changelog-fragments.mdandreference/design-rationale.mdhold the moved explanations. The three native-surface descriptions move into the existingreference/native-commit.md.commit-*eval cases never fired the skill on main, so no round could be VALID. Each prompt now names the skill:commit-hook-rejection-no-bypass,commit-never-stage-everything,commit-no-push-no-prandcommit-trailer-model-from-session. Only the prompts changed; graders andcase.yamlare untouched.Verification
awkfrontmatter strip piped towc -con both copies printed 28967 and 25098./docs-hygiene:compress compare(freshcompare-labeler, before against after) returned VERDICT: PASS with no SEMANTIC LOSS and no AMBIGUITY rows.A repo-wide grep found no external citation of the moved text to repoint.
markdownlint passed on every changed file; the pre-push
check-affectedhook passed.Paired
commit-*eval. Command:claude plugin eval --case 'commit-*' --runs 2 --scaffold --ablation none --keep-temp --model claude-opus-5-5, Claude Code 2.1.317, under a capped scope.skills/commitswapped in. The two arms differ only in the commit skill.run-validity.py --runs 2 --scaffolded, with 12 of 12 traces resolving per arm. The only warning is that the judge model was not recorded.noise-reportat margin 0.05run-validity.pyRelated
🤖 Generated with Claude Code