Repository navigation
docs: replace restated upstream facts with pointers in code-tidying, planning, repo-fleet-hygiene - #12719
docs: replace restated upstream facts with pointers in code-tidying, planning, repo-fleet-hygiene#12719melodic-automation-lanes[bot] wants to merge 2 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
|
claude-security-review reviewed Security review: PR #12719, incremental (89887d0 → 17e75a6)I found no security issues. This was an incremental review of the two files changed since 89887d0, and I read every hunk in both. Both are Markdown skill bodies. Neither is a trusted path, a trust control or a plugin manifest, so there are no
Instruction-surface lens: neither change deletes, narrows or softens a rule. Each is a wording or pointer edit, and the rules each paragraph enforces are still there. Because I found no removed rule, I did not consult the protected-class register ( The PR context file contains no embedded instructions aimed at this lane. This lane has 0 earlier rounds with findings (cap 3), so the cap does not apply. The single prior post was a 0-finding summary with nothing to re-raise. critical-findings: 0 |
|
claude-review reviewed Incremental code review: PR #12719 (
|
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
The unattended merge path armed native auto-merge at head |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM6y_Pzf Lane-Thread: PRRT_kwDOTCGFQM6y_Pzj
|
pr-unblock / address-feedback finished round 1 of max 4 on 17e75a6. |
There was a problem hiding this comment.
The pr-verify verifier failed head 17e75a6abd1ea3f4339bafcadd0dd177ac43b058. What it wrote, as data:
Summary: Issue #12692: the diff covers all 28 rows across the 11 files in code-tidying, planning and
repo-fleet-hygiene. Each touched plugin has a changelog fragment, and CI's covering jobs passed
(https://github.com/melodic-software/claude-code-plugins/actions/runs/41584099998/job/125745659930).
One required item is still missing. The issue names a trigger-less stamp at
plugins/planning/skills/design/SKILL.md:393 and asks for its recheck trigger. The diff only
reflows that text: the stamp line now ends at `as of 2026-10-11;` and `recheck when` starts the
next line. Before the change, that line held `recheck` and was still flagged, so the check reads
one line at a time. The stamp is therefore still trigger-less, and the done-when item that
`check-stamps.sh --trigger-less` passes on the touched files is not met. Nothing shows CI ran that
script, and the PR body says it was not run.
- No steering text aimed at the reviewer was found in the PR body, comments or diff.
- plugins/code-tidying/skills/audit-dead-code/SKILL.md:142-145: r048 asked for links to gopls as
well as vulture and knip. gopls was dropped because its docs page has no exit-code section, as the
fix round explains. The run-health rule still covers it. A human may want to confirm this
departure from the row.
There was a problem hiding this comment.
Replaced by #12773, which fixes this. The stamp at plugins/planning/skills/design/SKILL.md:392-394 now opens its own line as as of 2026-10-11; recheck when that section changes the per-call question limit. check-stamps.sh --trigger-less on all 11 touched files: 0 findings, 49 candidates parsed. (It also passed before the join, because the trigger check reads the whole file: check-stamps.sh:451-464.) The gopls point is unchanged: the exit-code rule at audit-dead-code/SKILL.md:142-145 still covers gopls, and its command-line page documents no exit codes to link.
There was a problem hiding this comment.
The pr-verify verifier failed head 17e75a6abd1ea3f4339bafcadd0dd177ac43b058. What it wrote about this file, as data:
- plugins/code-tidying/skills/audit-dead-code/context/adjudication.md:31-33 and
plugins/planning/skills/draft-goal-condition/SKILL.md:130-131: `as of` and its date are split
across two lines. Check that check-stamps.sh still finds these as stamps, or keep `as of
2026-11-03; recheck when` together on one line, as the other new stamps do.
There was a problem hiding this comment.
Fixed in replacement #12773. as of and its date were on different lines at adjudication.md:32-33 and draft-goal-condition/SKILL.md:130-131, so the stamp checker never parsed either date. Both now read as of 2026-11-03; recheck when ... on one line. On the touched files, the check-stamps.sh --trigger-less candidate count went from 47 to 49, so both are now seen, with 0 findings.
There was a problem hiding this comment.
The pr-verify verifier failed head 17e75a6abd1ea3f4339bafcadd0dd177ac43b058. What it wrote about this file, as data:
- plugins/planning/skills/design/SKILL.md:392-393: the stamp `as of 2026-10-11;` still has no
recheck trigger on its own line, because the reflow moved `recheck when ...` to the next line. Put
`as of 2026-10-11; recheck when that section changes the per-call question limit` on one line
(re-wrap the text around it as needed), then run
`plugins/attribution/skills/audit/scripts/check-stamps.sh --trigger-less` on every touched file
and report the result.
There was a problem hiding this comment.
Fixed in replacement #12773. plugins/planning/skills/design/SKILL.md:393 now reads as of 2026-10-11; recheck when that section changes the per-call question limit on one line. check-stamps.sh --trigger-less on every touched file: 0 findings, 49 candidates parsed, 0 declined.
There was a problem hiding this comment.
The pr-verify verifier failed head 17e75a6abd1ea3f4339bafcadd0dd177ac43b058. What it wrote about this file, as data:
- plugins/planning/skills/plan/SKILL.md:320: the /plan routing gate basis now reads 'the records in
reference/native-plan.md' (changed in the review fix round). This is fine, but it rewords a
contract-checked sentence beyond what the row asked for.
There was a problem hiding this comment.
Not changed in replacement #12773. The clause dropped from the gate basis ("not gated behind a setting, though a host may lack it") restated upstream behavior of /plan on line 320, which row r357 of #12692 names. The basis now points at the records in reference/native-plan.md. The sentence keeps its If /plan is available in your session (gate basis: ...) shape, and overlap.py self-check passes: 74 rows checked, no broken rows, version advisories only.
There was a problem hiding this comment.
The pr-verify verifier failed head 17e75a6abd1ea3f4339bafcadd0dd177ac43b058. What it wrote about this file, as data:
- plugins/repo-fleet-hygiene/skills/audit/SKILL.md:341-344: r406 links gitforwindows.org 'Creating
directory junctions' instead of the retired wiki page the issue names. That page does not document
how Git Bash tests a junction, so the pointer is a substitute, not the section the issue named.
There was a problem hiding this comment.
Not changed in replacement #12773. The page #12692 named, https://github.com/git-for-windows/git/wiki/Symbolic-Links, now holds only "This wiki page has been migrated to a new location: https://gitforwindows.org/Symbolic-Links". That page has a #creating-directory-junctions heading, which is the pointer used. The row marked this pointer "(confirm the section)" and asked to drop the junction-test claim. That claim is gone, so nothing local depends on how Git Bash tests a junction. The recheck trigger at repo-fleet-hygiene/skills/audit/SKILL.md:344 says to revisit if the page starts covering it.
|
pr-unblock / address-feedback finished round 2 of max 4 on 17e75a6. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=12719 -f activity=address-feedback |
Closes #12692
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
Verification
The runner ran each check from the base copy against 89887d0:
The run reports:
gopls checkdocumentationmultipleallows a string array/plan \[description\]rowlistentry says the main worktree is listed first; 'List output format' is #_list_output_formatLeft out: the items under Not verified.
Related
#12692