Skip to content

docs(source-control): a re-drafted PR keeps its ready head's venue #12747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 3 commits into from
Nov 3, 2026
Merged

docs(source-control): a re-drafted PR keeps its ready head's venue #12747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c30751
docs(source-control): a re-drafted PR keeps its ready head's venue
kyle-sexton Nov 3, 2026
2a6e5ad
Merge branch 'main' into docs/draft-head-venue-wording
kyle-sexton Nov 3, 2026
6576884
Merge remote-tracking branch 'origin/main' into docs/draft-head-venue…
kyle-sexton Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/source-control/fix-draft-head-venue-wording-8994a1c2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Fixed

- state that only a head pushed while the PR is a draft reads `local`; a PR moved back to draft keeps its ready head's test-lane results
7 changes: 4 additions & 3 deletions plugins/source-control/skills/pull-request/reference/ready-for-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,10 @@ command below. Report the verify line as that result, with the suites `skipped (
and the venue line's detail, naming the suites skipped: the list `scripts/affected-tests.sh`
prints with no arguments, run from `$PR_TREE`, when the repository ships it, otherwise the
test-lane names the venue line gives. When the line reads `local`, the venue cannot be read, or
the run passed `--verify-local`, the gate runs in full as below. A draft's head always reads
`local`: a draft skips the test lanes, so its first flip runs the suites here up to the budget and
leaves the rest to CI. `ci-status` gates the merge either way.
the run passed `--verify-local`, the gate runs in full as below. A head pushed while the PR is a
draft reads `local`: a draft skips the test lanes, so its first flip runs the suites here up to the
budget and leaves the rest to CI. A PR moved back to draft keeps the results of a head pushed while
it was ready. `ci-status` gates the merge either way.

- `verify` ran: after the rest of §1.5, run its deterministic last part and the record as one
shell command, so `pass` is never typed by hand. The gate runs the PR worktree's own
Expand Down
4 changes: 2 additions & 2 deletions plugins/source-control/skills/pull-request/reference/review-venue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ skipped copy a label or body edit posts never hides a failure:
- **`tests ci healthy: <detail>`**: every test-lane check run on the head finished as success,
skipped (a lane the change gave no work) or neutral, and at least one succeeded.
- **`tests local absent: <detail>`**: the head has no test-lane check run, every one skipped, or
the head has more check runs than the script reads. A draft skips them, so a draft's head reads
`absent`.
the head has more check runs than the script reads. A draft skips them, so a head pushed while
the PR is a draft reads `absent`; a PR moved back to draft keeps its ready head's results.
- **`tests local pending: <detail>`**: a test-lane check run on the head has not finished.
- **`tests local failing: <detail>`**: one concluded otherwise, such as failure, cancelled or timed
out.
Expand Down
Loading