Skip to content

refactor(plugin-quality): fold repeated resets and patterns in the audit collectors #12763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melodic-automation-lanes wants to merge 1 commit into from
Closed

refactor(plugin-quality): fold repeated resets and patterns in the audit collectors #12763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...s/plugin-quality/chore-tidy-adhoc-plugins-plugin-quality-2026-11-03-8ec3e79c.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Changed

- Tidied the audit collectors: one per-heading state reset in collect-categories.sh, a guard clause and a single declaration alternation in collect-standards.sh.
9 changes: 3 additions & 6 deletions plugins/plugin-quality/skills/audit/scripts/collect-categories.sh
View file
Open in desktop

@github-actions github-actions Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head fe36dc42ade5a08f2485290ca6d9916900dc5032. What it wrote, as data:

Summary: PR #12763 has no spec to judge against. spec-text.json is an empty array: the PR closes no
  issue, has no `Refs:` line, and no trusted pull-request entry was recorded. The rules require
  `fail` when no spec exists. The diff itself, a no-behavior-change tidy of two plugin-quality audit
  collectors, looks correct, and test-bash (0) and lint-shell passed on the judged head.
- pr-verify-data/spec-text.json: holds no entry. The PR body says "No related issue", so there is no
  outcome or done-when list to judge against. To fix, link a trusted issue (Closes or Refs) that
  asks for this tidy, or give the PR a title and body from a trusted author or script so the spec
  file records it.
- CI evidence: test-bash (0)
  https://github.com/melodic-software/claude-code-plugins/actions/runs/41590658483/job/125818376163
  and lint-shell
  https://github.com/melodic-software/claude-code-plugins/actions/runs/41590658483/job/125818424314
  both concluded success on the judged head.
- plugins/plugin-quality/skills/audit/scripts/collect-categories.sh:225: moving the
  marker/items/finding_open reset to straight after close_section() resets the same state on every
  `## ` heading path before `next`. It looks equivalent. No defect.

@melodic-automation-lanes melodic-automation-lanes Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/plugin-quality/skills/audit/scripts/collect-categories.sh:224

No code change made. The verifier failed this head only because the pull request has no spec to judge against (no Closes or Refs line, no trusted spec entry). It names no defect in this file. I read the code: at collect-categories.sh lines 223-227, every heading line runs close_section() and then resets marker, items and finding_open before any branch reaches next. That covers the Blindspots path too, so the reset is equivalent to the earlier per-branch resets. The fix the verifier names is to link a trusted issue or give the pull request a trusted title and body. That is a change to the pull request's metadata, not to a file, so a person needs to decide it.

@kyle-sexton kyle-sexton Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settled in owner-login replacement #12811. The only failure here was the missing spec; #12811 carries a trusted title and body that state it (a structure-only tidy with unchanged output). The verifier found no defect at collect-categories.sh:225, and the reset still runs after close_section() on every heading path. #12811 also adds tests that pin the folded suppressor regex in collect-standards.sh. This PR is held as superseded.

Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,12 @@ BEGIN {
line = trim($0)
if (line ~ /^## /) {
close_section()
marker = ""
items = 0
finding_open = 0
name = substr(line, 4)
if (name == "Blindspots" || name == "Doc-worthy gotchas" || name == "Unverified claims") {
section = ""
marker = ""
items = 0
finding_open = 0
next
}
if (name != "Errors" && name != "Improvements" && name != "Quality of life" &&
Expand All @@ -240,9 +240,6 @@ BEGIN {
} else {
section = name
}
marker = ""
items = 0
finding_open = 0
next
}
if (section == "" || line == "") next
Expand Down
7 changes: 2 additions & 5 deletions plugins/plugin-quality/skills/audit/scripts/collect-standards.sh
View file
Open in desktop

@github-actions github-actions Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head fe36dc42ade5a08f2485290ca6d9916900dc5032. What it wrote about this file, as data:

- plugins/plugin-quality/skills/audit/scripts/collect-standards.sh:117: `[[ -f "$file" ]] || return
  0` matches the old empty printf plus bare return (exit 0, no output). No defect.
- plugins/plugin-quality/skills/audit/scripts/collect-standards.sh:275: the folded regex
  `(export|declare[[:space:]]+-x|typeset[[:space:]]+-x)[[:space:]]+(MSYS_NO_PATHCONV|MSYS2_ARG_CONV_EXCL)`
  matches the same lines as the old three-way alternation. No defect.

@melodic-automation-lanes melodic-automation-lanes Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/plugin-quality/skills/audit/scripts/collect-standards.sh:117, plugins/plugin-quality/skills/audit/scripts/collect-standards.sh:275

No code change made. The verifier's notes on this file report no defect, and the code agrees. At line 117, cite() returns 0 with no output when the file is missing, which matches the old empty printf followed by a bare return. At line 275, the folded ERE matches export, declare -x or typeset -x, then whitespace, then MSYS_NO_PATHCONV or MSYS2_ARG_CONV_EXCL. Those are the same lines the old three-way alternation matched. The head failed because the pull request has no linked spec. That needs a person to link a trusted issue or supply a trusted title and body, and no edit to this file can fix it.

@kyle-sexton kyle-sexton Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settled in owner-login replacement #12811. The verifier found no defect at collect-standards.sh:117 or :275. #12811 adds collect-standards.test.sh cases that flag declare -x and typeset -x suppressors at their line and leave a per-command MSYS_NO_PATHCONV=1 ungraded, so dropping a form from the folded alternation now fails the suite (checked by removing typeset from the regex: two assertions fail). It also supplies the trusted spec this head lacked. This PR is held as superseded.

Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,7 @@ findings=0

cite() {
local file="$1" needle="$2" line
if [[ ! -f "$file" ]]; then
printf ''
return
fi
[[ -f "$file" ]] || return 0
line="$(grep -n -F "$needle" "$file" | head -n 1 | cut -d: -f1)"
printf '%s' "$line"
}
Expand Down Expand Up @@ -275,7 +272,7 @@ if [[ ! -f "$win_file" ]]; then
elif [[ -z "$win_cite" ]]; then
emit_probe windows-path-emit basis-missing "$win_rel" - "citation sentence absent"
else
export_line="$(grep -n -E 'export[[:space:]]+(MSYS_NO_PATHCONV|MSYS2_ARG_CONV_EXCL)|declare[[:space:]]+-x[[:space:]]+(MSYS_NO_PATHCONV|MSYS2_ARG_CONV_EXCL)|typeset[[:space:]]+-x[[:space:]]+(MSYS_NO_PATHCONV|MSYS2_ARG_CONV_EXCL)' "$COMPONENT" | head -n 1 | cut -d: -f1 || true)"
export_line="$(grep -n -E '(export|declare[[:space:]]+-x|typeset[[:space:]]+-x)[[:space:]]+(MSYS_NO_PATHCONV|MSYS2_ARG_CONV_EXCL)' "$COMPONENT" | head -n 1 | cut -d: -f1 || true)"
if [[ -n "$export_line" ]]; then
emit_probe windows-path-emit finding "$win_rel:$win_cite" "$COMPONENT:$export_line" "exported path-conversion suppressor"
else
Expand Down
Loading