Repository navigation
feat(docs-hygiene): rename-references auto-applies the Certain bucket and reports it #12786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
melodic-automation-lanes
wants to merge
2
commits into
main
from
work-resolve-issue/issue-12592-41586966486-1
+37
−9
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
.changes/docs-hygiene/work-resolve-issue-issue-12592-41586966486-1-affe032d.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - `/docs-hygiene:rename-references` apply mode no longer asks before applying the Certain bucket. | ||
| It applies those matches by default and reports the count, one or two example matches, and how | ||
| to review the bucket one match at a time instead. The proceed/abort gate, the Chain-context | ||
| prompt and the per-match Ambiguous prompts are unchanged. (#12592) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advisory: this eval uses a blocklisted token, so it can fail for a reason unrelated to the change.
verifyis on the English-verb blocklist (triage.mdL92).SKILL.mdL159 says triage "forces these into ambiguous bucket regardless of regex hit position", and L189 says "If a token is in the blocklist, force into ambiguous regardless of position". Onlypatterns.mdPhase 0 (L488) limits the blocklist to Form 2 and the chain forms, which would keep/verifyslash-tokens and paths Certain.How it fails: a model that follows
SKILL.mdputs every/verifymatch in Ambiguous. The Certain count is then 0, so expectation 2 ("The report gives the Certain count, one or two example matches…") fails and the per-match Ambiguous prompts run. The eval then fails on a blocklist-precedence question instead of the Certain-bucket behavior it is meant to test.Fix: use a token that is not on the blocklist, so the eval tests only this change. For example:
The
SKILL.mdwording conflict is older than this PR. This comment is only about which token the new eval uses.claude-lane: claude-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #12805, the owner-login replacement for this PR: eval 49 now renames
/deploy-docsto/publish-docs, which is not on the blocklist (context/triage.md:92), so it tests only the Certain-bucket behavior. The olderSKILL.mdversuspatterns.mdPhase 0 wording conflict is left out of this change.