Repository navigation
feat(docs-hygiene): rename-references auto-applies the Certain bucket and reports it #12805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
782a897
69ddaec
3a3732d
7aef80a
2f60e5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - `/docs-hygiene:rename-references` apply mode no longer asks before applying the Certain bucket. | ||
| It applies those matches by default and reports the count, one or two example matches, and how | ||
| to review the bucket one match at a time instead. The proceed/abort gate, the Chain-context | ||
| prompt and the per-match Ambiguous prompts are unchanged. (#12592) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -610,6 +610,18 @@ | |
| "Both Certain edits are applied after the proceed answer", | ||
| "The one-by-one route uses the per-match format with a \"skip remaining Certain\" option" | ||
| ] | ||
| }, | ||
| { | ||
| "id": 50, | ||
| "name": "certain-bucket-auto-applies-and-reports", | ||
| "prompt": "Rename the skill /deploy-docs to /publish-docs. The sweep finds only slash-token and path references.", | ||
| "expected_output": "Every match is a Form 1 slash-token or Form 3 path, so all of them land in the Certain bucket. The skill reports the bucket counts with the Certain count and one or two example matches, says the user can answer \"review Certain one-by-one\" to review them per match instead, and gates only the proceed/abort decision. It asks no separate \"auto-apply N matches?\" question for the Certain bucket; on proceed, Phase 5 edits every Certain match.", | ||
| "files": [], | ||
| "expectations": [ | ||
| "No `AskUserQuestion` asks whether to auto-apply the Certain bucket", | ||
| "The report gives the Certain count, one or two example matches, and how to review the bucket one by one instead", | ||
| "The proceed/abort gate still runs before any edit" | ||
| ] | ||
|
Comment on lines
+614
to
+624
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Advisory: eval 50 repeats eval 49 with weaker checks. Eval 49 at L600-L613 (from main) already tests the same scenario: every hit is Certain, no Certain-specific Eval 50's three expectations are all covered by eval 49. If eval 50 fails, it can only fail for a reason eval 49 also catches, so it adds run cost and nothing new. This eval was meant to replace eval 49's Fix: either
claude-lane: claude-review |
||
| } | ||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: this fragment repeats a change that has already been released.
plugins/docs-hygiene/CHANGELOG.mdL3-L7 on head already has## [2.5.0] - 2026-11-03with this exact change: the Certain bucket no longer asks, the report gives the count, examples and one-by-one route, and the gate, Chain-context and Ambiguous buckets are unchanged (#12593, #12592). Main shipped it after this branch was cut.If this fragment is merged, the next release will:
bump: minor), though nothing new reaches users. The only remainingapply.mdedits are the heading and the Phase 5 sentence, which add no behaviour;### Changedentry under 2.6.0.Fix: delete the fragment. If you want the Phase 5 wording recorded, use a
bump: patchfragment that describes just that wording change.claude-lane: claude-review