Repository navigation
refactor(visualization): route check-deck's K2 refusal through its local-result helper - #12806
Conversation
…cal-result helper
…zation-2026-11-03' into fix/12765-replacement
… by name local() took an open extra object spread after the fixed keys, so a caller could overwrite medium or class. It now takes the refusal list as its one optional argument. A test pins the K2 refusal's key order and checks other refusals carry no refused key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vcupom3BKF6QuC5U3sRJPj
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #12806I found no security issues in this pull request. I read every hunk of all 3 changed files. What changed:
Security reasoning:
Prior findings: none (0 rounds, cap 3, not past the cap). critical-findings: 0 |
|
claude-review reviewed Code review: no findings. I read every hunk of all 3 changed files. The PR spec (title and body; no closing issue) asks for two things: send check-deck's K2 refusal through
I did not run the tests. The 55/55 pass and the There are no prior findings and no settled threads. The round cap (3) does not apply. |
|
Unattended merge: risk MED at head |
No related issue: code-tidying upkeep sweep.
Summary
Replaces #12765, the lanes App's tidy of
plugins/visualization/skills/present/scripts/check-deck.mjs, as an owner-login pull request. The pr-verify verifier failed #12765 only because it had no spec: it linked no issue and a lanes App body is not trusted spec text. pr-unblock's address-feedback lane could not supply one with a file change, left the fail-note thread open as UNCERTAIN, and labeled the PRneeds-session. This pull request's title and body are the spec: route check-deck's K2 refusal through its local-result helper without changing the printed JSON, and listhostedin the header usage comment.Fix
checkDeck'slocal()helper builds the K2 refusal, and the header usage comment listshostedamong the--argumentvalues, matching the parser and the printed usage line.local()now takes the refusal list as its one optional argument instead of an openextraobject spread after the fixed keys. Both review lanes on refactor(visualization): route check-deck's K2 refusal through its local-result helper #12765 noted that the spread could overwritemediumorclass; a named argument removes that.medium,class,reason,refused) and checks that other refusals carry norefusedkey..changes/visualization/patch fragment (from refactor(visualization): route check-deck's K2 refusal through its local-result helper #12765).Verification
bash plugins/visualization/tests/present.test.sh: 55/55 pass.scripts/check-affected.sh --base origin/main --no-fetch: 13 passed, 2 skipped (no changed shell or Python).Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vcupom3BKF6QuC5U3sRJPj