Repository navigation
fix(work-items): read pr-review-main in the morning brief's default lanes - #12851
Conversation
…anes The morning brief's KEY line counts credit-stop records per lane, but pr-review-main.yml was not in DEFAULT_LANE_WORKFLOWS, so a live run read its records only when --lane-workflows named it. Add it, with a live-REST test case that finds it in the workflow list and reports its run. Refs: #12526 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsI read every hunk of all 3 changed files: the changelog fragment, What changed. Tests.
Manifest and changelog. No Closing issue. None. The PR uses Paved paths and rules. I did not resolve the project's standards index or read the Prior findings. None (0 earlier rounds, cap 3). The PR context had no embedded instructions. Spend (not a finding). Live morning-brief runs on repos that have |
|
claude-security-review reviewed Security review: PR #12851I found no security issues. I read the full diff for all 3 changed files. What changed
Checks
Spend: none beyond one more workflow's run, job and annotation records read through the GitHub REST API when the brief runs live. That is API quota, not a billed resource. critical-findings: 0 |
Refs: #12526
Summary
The morning brief's
KEY:line counts each lane's credit-stop records, butpr-review-main.ymlwas missing from its default lane list (plugins/work-items/skills/morning-brief/scripts/morning-brief.sh,DEFAULT_LANE_WORKFLOWS). A live run read that lane only when--lane-workflowsnamed it. This was the gap the measurement comment on #12526 found.The other part of #12526's follow-up, moving both workflows to the check-key-credit marker gate from melodic-software/ci-workflows#973, is not in this PR. It already ships in two other PRs:
pr-review-main.yml: merged in #12838 (pinned atbc62beb, the disk-hygiene(test): isolate run_guard_powershell enabled flag from ambient argv in test_hygiene #973 merge commit, with the marker write and upload steps).pr-verify.yml: open in #12799, owned by another session.Fix
pr-review-main.ymltoDEFAULT_LANE_WORKFLOWS.morning-brief.test.sh: the live-REST case's workflow list now includespr-review-main.ymlwith one passing run, and the test asserts that the Lanes section reports it (runs=1 failed=0).Verification
bash plugins/work-items/skills/morning-brief/morning-brief.test.sh: 532 pass, 0 fail. Before the fixture fix, the keys-live cap case failed twice, because the copied fixture gave pr-review-main a run inside the 200-run cap. It now gives pr-review-main no runs.bash plugins/work-items/skills/morning-brief/morning-brief-view.test.sh: 14 pass.#12526 stays open (
Refs:, notCloses). Its last done-when step is a re-measure after #12799 merges, run from REST job lists the way the measurement comment on #12526 did:KEY_CREDIT_WINDOW_HOURSwindow. Before the marker gate, pr-verify made 45 calls in 2.6 h.Related
🤖 Generated with Claude Code