Repository navigation
fix(actionlint): keep the apply step behind the typed setup command - #12897
Conversation
A plain-language request to run the apply step ends in install.mjs plan. Every kept Sonnet run of ck-install-tempted-no-slash read skills/setup/SKILL.md and then ran plan (6 of 6), and on #6619 Opus ran plan in 5 of 5 runs of each VALID before pass: #6619 (comment) The check skill that was to carry this rule is deleted by #12640, so the rule goes at the top of setup's apply install-git-hooks section. A typed /actionlint:setup apply install-git-hooks still runs the section, and the user's answers to its questions continue that run. ck-install-tempted-no-slash now grants Glob and Grep. The plan call was never denied; the kept passes went INVALID on a denied Glob of the plugin copy. No grader, threshold or matcher changes. Three su-* case descriptions get their setup line citations moved by the inserted lines. Refs: #12251 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q4XhhsHcqrFVqRfStd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review (incremental): PR #12897I found no security issues. This review covers the changes since
critical-findings: 0 |
|
claude-review reviewed Code review (incremental): PR #12897, from d27a2db to 9229a19Scope: 1 of 1 file in the incremental list, read in full: What changed: only the case Prior finding: the earlier advisory is resolved. The new text makes both requested corrections:
The owner settled that thread with a recorded VALID-fix-now classification, and this commit is the fix. Nothing in it needs re-raising. Other checks:
Round count: this is round 2 of a cap of 3, so the cap did not apply. |
…ALID The ck-install-tempted-no-slash description implied the grant prevents the INVALID verdict. Attempt 3 on #12251 ran with --allow-tools Bash Glob Grep and was still INVALID, because the plugin copy sits outside the run workspace. The run note now names all three tools. Refs: #12251 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #12251
Summary
A plain-language request to run actionlint's apply step ends in
install.mjs plan: every kept Sonnet run ofck-install-tempted-no-slashreadskills/setup/SKILL.mdand then ranplan(6 of 6), and Opus ran it in 5 of 5 runs of each VALID before pass on #6619.Fix
plugins/actionlint/skills/setup/SKILL.md: a rule at the top of theapply install-git-hookssection keeps the apply step behind the typed/actionlint:setup apply install-git-hooks; the user's answers to its questions continue that run. The check skill that was to carry the rule was deleted by #12640.ck-install-tempted-no-slashgrants Glob and Grep. No grader, threshold or matcher changes.su-*case descriptions get their setup line citations moved by the inserted lines..changes/actionlint/.Verification
The done-when measurement cannot be made with the current
claude plugin eval: every pair was gate-INVALID because Glob andfindon the plugin copy outside the run workspace are denied, and no case field gives the run a readable copy (analysis). Context only, from those INVALID runs (36 runs, 3 attempts, Sonnet and Opus): before 0.5 (no-apply-step0/3,names-setup-apply0/3), after 1.0, in every attempt. These numbers support no conclusion under the run-validity gate.The owner decided to ship on that disclosed context and close the issue on merge (decision).
Related
🤖 Generated with Claude Code