Repository navigation
fix(review): have code-reviewer read its bundled files with the Read tool - #13092
Conversation
…tool The code-reviewer agent read context/severity.md and the quality-gate code-design criteria through Bash cat and sed by the plugin's absolute path. In the #12505 reviewer-diversity eval those shell reads were denied in 4 runs while every Read of the same files succeeded, so the suites were judged INVALID. Name the Read tool for every bundled file the agent reads. Refs #12505 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #13092No security issues found. I read every hunk of both changed files.
Neither file matches a listed trusted path. No critical-findings: 0 |
|
claude-review reviewed Code review: no findings. I read both changed files in full:
The path-scoped rule Closing issue: the PR context says only Unverified author claims: the PR says No plugin manifest changed, so there are no manifest lines. Prior findings: none, round 0 of 3, cap not reached. No security lane was needed for this change, and I found no embedded instructions in the PR context. |
Refs: #12505
Summary
The
review:code-revieweragent read its bundled reference files (context/severity.md,skills/quality-gate/context/code-design.md) through Bashcatandsedby the plugin's absolute path. In the #12505 reviewer-diversity eval those shell reads were denied, which made the L arm's two-defect suite and the pilot suites INVALID under the run-validity gate.Fix
plugins/review/agents/code-reviewer.md: one**Bundled files.**line telling the agent to read every${CLAUDE_PLUGIN_ROOT}file it names with theReadtool, never through Bash.review.Why the agent changes and the eval setup does not: in the round-2 L kept traces,
code-reviewersubagents'ReadandGrepof these files succeeded 49 times with no denial, while 4 of their 13 Bash reads were denied. The suites already grantBash, so no eval flag allows those reads short of a permission change.Readis the file-read tool and the path that never hit a denial; whether a real session prompts on the shell reads is unverified.Verification
scripts/check-affected.sh --testson the committed head: 14 passed, 3 skipped.Remaining on #12505
Related
🤖 Generated with Claude Code