Repository navigation
fix(review): have the sweep wait for the workflow result, not read its run directory - #13167
Conversation
…s run directory Refs: #12505 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsThis PR changes the What I checked:
Verification: The PR's verification ( There were no prior findings (round 0 of 3), no settled threads, and no plugin manifest changes. Neither changed file matches a trusted path. |
|
claude-security-review reviewed Security review: PR #13167No security issues found. I read every hunk of both changed files.
Neither file matches a trusted-path glob. The PR changes no plugin manifest, workflow, token, kill switch, trusted-actor list or merge hold. The PR description contains no embedded instructions aimed at this lane. Spend: none. The PR changes no turn limits, model, effort or run counts. critical-findings: 0 |
Refs: #12505
Summary
The #12505 reviewer-diversity eval's L decoy suite was INVALID in round 4 (#13159's head), and round 3 failed the same way. In both, the main session read its own
review:fanout-sweepworkflow's run directory. Round 4's two denied cases show both shapes:lsof the run directory, after the backgroundWorkflowlaunch and before its completion notification.grepof the run'sjournal.jsonlfor one leaf's text, after the completion notification. The result file that notification names already held that leaf's full text in the workflow'srawarray (raw: returned.map(r => ({ label, output })),workflows/fanout-sweep.js:265).Fix
plugins/review/skills/fanout/context/run-everything-mode.md:rawentry'soutputin the result the notification names, or from itsfindingsPathsfile, and never from the run directory.review.Verification
scripts/check-affected.sh --testson the committed head: 15 passed, 2 skipped.Remaining on #12505
Related
🤖 Generated with Claude Code