Repository navigation
fix(pr-pipeline): strip triage and host-run state labels from every closed issue - #13293
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iled work a spec Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: PR #13293, incremental (13f9ec0 → 9682e17)No findings. This pass was blocking only, because the lane already reviewed an earlier head. I read the one file in scope, What changedThe push adds one test:
What I checked
Prior and settled threads
Other notes
|
|
claude-security-review reviewed Security review: PR #13293 (incremental, head 9682e17)I found no security issues in this push. Scope. This was an incremental review of the changes since What changed. The push adds one test, "closing a split parent removes its state labels after the close and keeps attended". It asserts the order of writes when a split parent is closed:
The test only uses mocks and touches no production code, gates or trust controls. It checks that the Prior findings. The last review had no findings, so there is nothing to carry forward or repeat. This review was blocking only: it would have reported only CRITICAL or IMPORTANT findings, and it found none. critical-findings: 0 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: hub ledger L291 (state labels left on closed issues) and L290 (spec for Bot-filed issues).
Summary
#12865 strips only the queue labels (
agent-ready,status: ready,admission-deferred; report-outcome.mjs:678) when an issue closes. Triage'sstatus:labels andhost-runstay: 15 of the 40 most recently updated closed issues carried one at 16:2xZ (for example #5946, #13238, #10022).Fix
stripStateLabels(report-outcome.mjs) removesstatus: confirmed,status: needs-decision,status: needs-infoandhost-runfrom a closed issue.attendedstays, since only a listed human lifts it.stripClosed), the split-parent close (closeDoneParent) and report-outcome's close route. On the two lanes App closes it runs after the PATCH, so a failed close never leaves an open issue without its state. The queue strip still runs before the close, as it did.intake-reenterandsecurity-outside-actoronunlabeled, and both skip a closed issue's event at the jobif(intake-reenter.yml:66-68, security-outside-actor.yml:70-72). That is two skipped runs per label and no runner. Nothing reads these labels on a closed issue: a search of.github/scriptsfor closed-issue label reads finds none.Verification
node --test .github/scripts/work-unblock/label-unblocked.test.mjs .github/scripts/work-resolve-issue/report-outcome.test.mjs: 715 pass, 0 fail. New tests cover the label order on the close run and on report-outcome's close, with state labels after the close andattendedkept.scripts/check-affected.sh --base origin/main --no-fetch: 11 passed, 5 skipped.Related
🤖 Generated with Claude Code