Conversation
Running the code meant leaving the keyboard for the Run tests button, which a candidate presses many times in an interview. The editor now takes Cmd+Enter as a shortcut for that button, and Ctrl+Enter where there is no Command key. The shortcut follows the button's disabled state, so it never starts a second run or fires while paused, and it does nothing once the interview has ended, where the button is left enabled under the ending overlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the code meant leaving the keyboard for the Run tests button, which a candidate presses many times in an interview. The editor now takes Cmd+Enter as a shortcut for that button, and Ctrl+Enter where there is no Command key. The shortcut follows the button's disabled state, so it never starts a second run or fires while paused, and it does nothing once the interview has ended, where the button is left enabled under the ending overlay.