[MOO-2364] Update to hermes-compiler v1 (19.x.x)#1269
Open
MxKevinBeqo wants to merge 8 commits into
Open
Conversation
MxKevinBeqo
added
enhancement
…piler pinning in package.json
| - hermes-engine (0.15.1): | ||
| - hermes-engine/Pre-built (= 0.15.1) | ||
| - hermes-engine/Pre-built (0.15.1) | ||
| - hermes-engine (250829098.0.9): |
Collaborator
There was a problem hiding this comment.
this one is still using the old version
| // The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map" | ||
| // hermesFlags = ["-O", "-output-source-map"] | ||
|
|
||
| def hermescDir = file("${rootDir}/../node_modules/react-native/node_modules/hermes-compiler/hermesc") |
Collaborator
There was a problem hiding this comment.
not sure why do we need this override - hermes compilation is done by Studio Pro, not NT
Contributor
Author
There was a problem hiding this comment.
This is basically only for the CI pipeline because it runs the bundle generation task createBundleDevDebugJsAndAssets.
From what I saw, the variant we build in the pipeline is not in the debuggableVariants, so it does the js compilation - bundling as well.
I did a quick search on removing the bundling as a task from the command in the CI file, and in theory it could be done e.g.
run: ./gradlew assembleDevDebug -x :app:createBundleDevDebugJsAndAssets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR updates the used native hermes-compliler to v1, following the react-native upgrade to 0.84.1.
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
This PR contains