[WC-3517]: Set default max height to 250px for Image widget#2351
Open
r0b1n wants to merge 1 commit into
Open
Conversation
New Image widgets now default to a 250px maximum height instead of None. Existing widgets with the old default are not affected. Closes WC-3517
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Currently the Image widget defaults to no maximum height (
None). This change sets the defaultmaxHeightUnittopixelsandmaxHeightto250in the widget XML, so newly placed Image widgets come with a 250px maximum height out of the box.Existing widgets are not affected — Mendix only applies XML default values when a widget is first added to a page, so previously placed widgets retain their current settings.
JIRA: WC-3517
What should be covered while testing?
Pixelsand Maximum height is250by default.