Repository navigation
BUG: correctly handle empty directories when checking package splits - #913
Merged
Merged
Conversation
dnicolodi
force-pushed
the
fix/package-split
branch
2 times, most recently
from
September 29, 2026 07:24
afacb41 to
a14cb2e
Compare
The exclude_files and exclude_dir arguments can make install_subdir() do not install any files. Empty directories are not added to the wheel thus do not contribute to make a package split. However, the check for packages split across platlib and purelib was done before determining whether install_subdir() installed any file, resulting in false positives. Move the check after all wheel content has been added to the manifest. This requires a second iteration over the wheel content, but it can be avoided in the vast majority of cases where a package installs modules either only in platlib or in purelib. Fixes mesonbuild#869.
The test wanted to include Meson 1.1.0 pre-releases, but there was a typo in the minor version that made it match only 1.2.0 pre-releases instead. At this point in time including pre-releases is not relevant anymore, thus simplify the guard to check only for version 1.1.0 or later.
dnicolodi
force-pushed
the
fix/package-split
branch
from
September 29, 2026 07:36
a14cb2e to
84d0bc4
Compare
rgommers
added
the
maintenance
rgommers
approved these changes
Oct 2, 2026
rgommers
left a comment
rgommers
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @dnicolodi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #869.