Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 (Humble)#328
Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 (Humble)#328Narukara wants to merge 1 commit intomicro-ROS:humblefrom
Conversation
add support for 5.3, 5.4
|
About atomic operations: All the required atomic operations — which are also the ones provided by
All of these are fully provided in newer versions of ESP-IDF. |
|
@Amronos Thank you for accepting my proposal! I'd like to confirm what exactly the criteria are for "tested" in the README. Does it require running each example program on actual hardware? Also, what's your plan — are you thinking of adding support to the rolling branch first and then backporting to other branches? I'm wondering if maybe this PR isn't suitable for merging. |
Since I am not a maintainer of this repo, I am not too sure.
The general pattern I have seen in other repositories is to merge everything first to rolling and then perform backports through tools like mergify for consistency between branches. Another thing: |
I'm glad to join. But I think we should check with the maintainers first... @pablogs9 @EugenioCollado Actually, I'm planning to adapt this library for ESP-IDF 6.0 and above. Also, to add this library to the ESP Component Registry. |
|
Agreed with everything. I will make a post in about a week if there is no response. |
Since newer versions of ESP-IDF provide complete atomic operations, we can disable the 64-bit atomic extension in
micro-ROS/rcutilsand remove the complexpatch_atomicmechanism. See #251.Remove unnecessary
sedcommands inlibmicroros.mkto ensure compatibility with ESP-IDF 5.5.4. See #327.Added support for ESP-IDF 5.3 and 5.4 (already verified through CI checks in my fork).