Skip to content

Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 (Humble)#328

Open
Narukara wants to merge 1 commit intomicro-ROS:humblefrom
Narukara:fix/remove_patch_atomic
Open

Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 (Humble)#328
Narukara wants to merge 1 commit intomicro-ROS:humblefrom
Narukara:fix/remove_patch_atomic

Conversation

@Narukara
Copy link
Copy Markdown

Since newer versions of ESP-IDF provide complete atomic operations, we can disable the 64-bit atomic extension in micro-ROS/rcutils and remove the complex patch_atomic mechanism. See #251.

Remove unnecessary sed commands in libmicroros.mk to ensure compatibility with ESP-IDF 5.5.4. See #327.

Added support for ESP-IDF 5.3 and 5.4 (already verified through CI checks in my fork).

add support for 5.3, 5.4
@Narukara Narukara changed the title Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 Remove atomic patch & sed for flags, add support for idf 5.3, 5.4 (Humble) Apr 14, 2026
@Narukara
Copy link
Copy Markdown
Author

Narukara commented Apr 14, 2026

@Amronos Amronos mentioned this pull request Apr 15, 2026
@Narukara
Copy link
Copy Markdown
Author

@Amronos Thank you for accepting my proposal!

I'd like to confirm what exactly the criteria are for "tested" in the README. Does it require running each example program on actual hardware?

Also, what's your plan — are you thinking of adding support to the rolling branch first and then backporting to other branches? I'm wondering if maybe this PR isn't suitable for merging.

@Amronos
Copy link
Copy Markdown

Amronos commented Apr 15, 2026

I'd like to confirm what exactly the criteria are for "tested" in the README.

Since I am not a maintainer of this repo, I am not too sure.
But I personally feel that it should be fine to test it one one or two different pieces of hardware and make sure everything builds fine in CI.
If any bugs occur, they can be fixed once reported.

Also, what's your plan

The general pattern I have seen in other repositories is to merge everything first to rolling and then perform backports through tools like mergify for consistency between branches.
That doesn't seem to be the case here as different PRs adding support for esp-idf v5.5 were directly merged to jazzy and humble.

Another thing:
The maintainers of this repo do seem a bit inactive; I am considering making a post on ros discourse or zulip to ask for maintenance rights to this repo so that we can get PRs merged faster. Would you like to join?

@Narukara
Copy link
Copy Markdown
Author

Another thing: The maintainers of this repo do seem a bit inactive; I am considering making a post on ros discourse or zulip to ask for maintenance rights to this repo so that we can get PRs merged faster. Would you like to join?

I'm glad to join. But I think we should check with the maintainers first... @pablogs9 @EugenioCollado

Actually, I'm planning to adapt this library for ESP-IDF 6.0 and above. Also, to add this library to the ESP Component Registry.

@Amronos
Copy link
Copy Markdown

Amronos commented Apr 16, 2026

Agreed with everything. I will make a post in about a week if there is no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants