refactor(cli): migrate commands to RunE with a single exit funnel#490
Open
Caesarsage wants to merge 4 commits into
Open
refactor(cli): migrate commands to RunE with a single exit funnel#490Caesarsage wants to merge 4 commits into
Caesarsage wants to merge 4 commits into
Conversation
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Contributor
Author
|
HOLD till PR #489 is review and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depend on #489
Part of the Microcks CLI v2 work (#255). Stacked on PR #489.
Run+ scatteredos.Exit/log.FataltoRunEreturning errors.cmd.Handle, called only bymain— prints to stderr and maps Failure Kind → exit code (cmd/exit.go). Nothing else exits.ErrTestFailedsentinel → exit1with no spurious error line (mirrorskubectl diff).No impact on the
microcksbinary: commands, flags, args, and success output are unchanged. Only code importing these packages is affected.Exit codes (new, user-visible)
0= success / non-zero = failure still holds, and1still means "contract test failed". Operational failures now carry distinct codes so CI can branch on why:These codes were previously undocumented and inconsistent (
1/2/20interchangeably), so there is no prior contract to break. Documented inREADME.md+documentation/error-handling.md.