fix(config): correct file permission error string formatting (fixes #… - #540
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add exact error-message assertions for Unix and Windows.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR corrects Unix and Windows file-permission error formatting and removes trailing punctuation.
Changes:
- Adds missing spacing and commas in error messages.
- Removes trailing periods for ST1005 compliance.
| File | Summary |
|---|---|
pkg/config/file_permission_unix.go |
Updates Unix permission error formatting. |
pkg/config/file_permission_windows.go |
Updates Windows permission error formatting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…icrocks#535) Signed-off-by: ish-g09 <ig.valiente09@gmail.com>
ish-g09
force-pushed
the
fix/file-permission-format
branch
from
September 23, 2026 16:59
cfdb20c to
1995477
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the error message returned by
getFilePermission()inpkg/config/file_permission_unix.goandpkg/config/file_permission_windows.go:flags: %s) and joined the concatenated string literals with a comma (%s, change ...), preventing terminal output words from running together.Related issue(s)
Fixes #535
How to test?
Run config package tests locally:
go test -v ./pkg/config/...