fix: use a private ServeMux for the SSO login callback server - #571
Closed
Sarthak-Shreshtha01 wants to merge 1 commit into
Closed
Sarthak-Shreshtha01 wants to merge 1 commit into
Sarthak-Shreshtha01 wants to merge 1 commit into
Conversation
Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
Sarthak-Shreshtha01
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
October 4, 2026 15:40
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSO login added its callback route to Go's shared global router. Starting a second login in the same process added the route again and made the CLI crash. Each login now uses its own router. I added
TestOAuth2LoginCanRunTwiceincmd/logout_test.go, which runs the login twice in a row.Fixes #549