Add connectionless Cast API support (cxless_connect, cxless_set_listener) - #3781
Open
naormeit wants to merge 1 commit into
Open
Add connectionless Cast API support (cxless_connect, cxless_set_listener)#3781naormeit wants to merge 1 commit into
naormeit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where casting silently fails on modern applications (e.g., YouTube, Netflix, Prime Video). These apps utilize the connectionless Cast API path by calling connect(), setting a listener via setListener(), and waiting for an onConnectedWithResult(0) callback. This connectionless flow was previously unimplemented in microG.
Fixes #580.
Changes:
ICastDeviceController.aidl: Added methods connect() (16), setListener() (17), and unregisterListener() (18).
ICastDeviceControllerListener.aidl: Added callback onConnectedWithResult(int) (13).
CastDeviceControllerImpl.java: Implemented the connectionless methods and added listener lifecycle management utilizing IBinder.DeathRecipient to ensure clean disconnections upon client death.
CastDeviceControllerService.java: Transitioned to onPostInitCompleteWithConnectionInfo, exposing the cxless_connect and cxless_set_listener feature flags so the modern Cast SDK recognizes microG's capabilities.
CastContextImpl.java: Added a session provider prefix fallback and unconditional media router callback registration.
MediaRouterCallbackImpl.java: Added null guards and an extras fallback within onRouteSelected.
Testing:
Local build passes successfully.
Hardware testing is pending (no Chromecast device is currently available for verification).