Skip to content

lora-sx126x: Enable all IRQ Mask bits unconditionally. #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
projectgus wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

lora-sx126x: Enable all IRQ Mask bits unconditionally. #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions micropython/lora/lora-sx126x/lora/sx126x.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,21 @@ def __init__(
# can trigger the ISR and may not be reset by the driver, leaving DIO1
# high.
if dio1:
self._cmd(
">BHHHH",
_CMD_CFG_DIO_IRQ,
(_IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT | _IRQ_CRC_ERR), # IRQ mask
(_IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT), # DIO1 mask
0x0, # DIO2Mask, not used
0x0, # DIO3Mask, not used
)
dio1.irq(self._radio_isr, Pin.IRQ_RISING)
dio1_mask = _IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT
else:
dio1_mask = 0

self._cmd(
">BHHHH",
_CMD_CFG_DIO_IRQ,
# The Irq Mask byte needs to be set so that _CMD_GET_IRQ_STATUS returns all
# relevant flags that driver might check
_IRQ_TX_DONE | _IRQ_DRIVER_RX_MASK,
dio1_mask, # DIO1Mask
0x0, # DIO2Mask, not used
0x0, # DIO3Mask, not used
)
dio1.irq(self._radio_isr, Pin.IRQ_RISING)

self._clear_irq()

Expand Down
Loading