Skip to content

[API tests] Support localized purchase-invoice payment discounts - #11226

Draft
Prangshuman Das (t-prda) wants to merge 13 commits into
prdas/646383-split-cancellation-reasonsfrom
prdas/646383-split-italian-discount
Draft

[API tests] Support localized purchase-invoice payment discounts#11226
Prangshuman Das (t-prda) wants to merge 13 commits into
prdas/646383-split-cancellation-reasonsfrom
prdas/646383-split-italian-discount

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Scope

Set invoice/posting dates before applying vendor defaults, use the payment-term discount fixture, and recognize payment discounts represented by the Italian localized payment-line table. The RecordRef/table-field contract and assertion remain explicit review points.

AB#646383 — follow-up split from PR #10085; link only, not an instruction to resolve the umbrella work item.

Evidence and limits

One observed IT failure: CU139729.TestPurchaseInvoiceWithPaymentDiscount in saved result sets 2 and 4. This preserves the proposed localized fixture/assertion change without claiming a fresh successful run.

Native GitHub stack #11232

This draft is stacked above #11225. #10085 is the bottom API-authentication fix. The review diff contains only this layer's fix plus removal of its 1 temporary method exclusions. Earlier layers are inherited, not repeated in this diff.

Existing PR/branch history is preserved; no force-push or merge into main was performed. NAV selection/company/native exclusions and existing out-of-scope Expense exclusions remain untouched.

Validation

  • Parent-tip ancestry and exact layer file scope verified; git diff whitespace checks and exclusion JSON validation passed.
  • Only this layer's listed temporary exclusions are removed; existing whole-codeunit exclusions are retained.
  • Full runtime validation of this stacked head is pending. Historical failures are issue evidence, not proof this head passes.
  • Repository CI currently filters PR base branches to main, releases/* and features/*; retargeted personal-branch layers do not automatically trigger that workflow on subsequent pushes. No workflow-policy expansion was made.

Methods re-enabled by this layer

  • 139729.TestPurchaseInvoiceWithPaymentDiscount

Split from the preserved PR10085 snapshot. AB#646383

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve published branch history and re-enable only the 1 methods covered by this layer.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
@t-prda
Prangshuman Das (t-prda) changed the base branch from main to prdas/646383-split-cancellation-reasons September 8, 2026 17:05
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant