Skip to content

[29.x] Chat v2 privacy notice behavior changed to not auto agree for Eval companies - #11271

Open
Tymon Mikula (Kimi310) wants to merge 1 commit into
releases/29.xfrom
private/t-tmikula/29.xHotfixEEAPolicyChat
Open

[29.x] Chat v2 privacy notice behavior changed to not auto agree for Eval companies#11271
Tymon Mikula (Kimi310) wants to merge 1 commit into
releases/29.xfrom
private/t-tmikula/29.xHotfixEEAPolicyChat

Conversation

@Kimi310

@Kimi310 Tymon Mikula (Kimi310) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fixes: AB#649638
Backport commit: d5ea8cc

Backports new behavior for chat v2 privacy policy to treat Eval companies as non-Eval companies

…mpanies (#11204)

Fixes:
[AB#649164](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/649164)

Description: Turning the skip the check for eval companies to false for
copilot chat privacy notice essentially changing the default behavior of
Eval company to the current behavior of non-Eval company.
@Kimi310
Tymon Mikula (Kimi310) requested review from a team September 9, 2026 13:45
@github-actions github-actions Bot added AL: System Application Team: Integrations GitHub request for Integrations area labels Sep 9, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change makes the Microsoft Copilot privacy notice use the same approval path for evaluation companies as it uses for other companies. The change is applied in both capability status evaluation and the approval prompt flow, so the capability cannot stay active by only relying on the old evaluation-company bypass.

The branch condition is narrow: only the Microsoft Copilot notice passes SkipCheckInEval = false; other required notices keep the old evaluation-company behavior. The default-approval logic for environments that can be on by default is still owned by the privacy notice registration code, so this fits the intended EEA trial behavior without changing public APIs or event signatures.

Problem-solution fit

Fit: Strong

The reported problem is that trial/evaluation companies should not bypass the Microsoft Copilot privacy notice in EEA scenarios. The diff changes the exact two places that read or confirm the required privacy notices for a capability, and it scopes the stricter behavior to the Microsoft Copilot notice.

Suggestions

None.

Risk assessment and necessity

Risk: The regression surface is limited to Copilot capability privacy notice checks in CopilotCapabilityImpl.Codeunit.al and CopilotSettings.Table.al. Evaluation companies with no explicit approval may now see the Microsoft Copilot capability as inactive in the stricter case, while non-Copilot notices keep their previous evaluation-company behavior. No public API, event signature, posting logic, or persisted schema changed.

Necessity: The change is needed so evaluation companies do not silently pass the Microsoft Copilot notice where the reported policy requires an explicit approval path. The implementation is small and matches the existing privacy notice extension point.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11271 round=1 by=alexei-dobriansky at=2026-09-09T22:22:26Z lastSha=fa82b96bf8631d8fdef9aead7ec39659be00fb9c reviewKey=b5bbcf122bcd8616d1ebfc958c0d00513131c34a78ec91d84a25c62f7c4a01bb suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: System Application Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants