[29.x] Chat v2 privacy notice behavior changed to not auto agree for Eval companies - #11271
[29.x] Chat v2 privacy notice behavior changed to not auto agree for Eval companies#11271Tymon Mikula (Kimi310) wants to merge 1 commit into
Conversation
…mpanies (#11204) Fixes: [AB#649164](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/649164) Description: Turning the skip the check for eval companies to false for copilot chat privacy notice essentially changing the default behavior of Eval company to the current behavior of non-Eval company.
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis change makes the Microsoft Copilot privacy notice use the same approval path for evaluation companies as it uses for other companies. The change is applied in both capability status evaluation and the approval prompt flow, so the capability cannot stay active by only relying on the old evaluation-company bypass. The branch condition is narrow: only the Microsoft Copilot notice passes SkipCheckInEval = false; other required notices keep the old evaluation-company behavior. The default-approval logic for environments that can be on by default is still owned by the privacy notice registration code, so this fits the intended EEA trial behavior without changing public APIs or event signatures. Problem-solution fitFit: Strong The reported problem is that trial/evaluation companies should not bypass the Microsoft Copilot privacy notice in EEA scenarios. The diff changes the exact two places that read or confirm the required privacy notices for a capability, and it scopes the stricter behavior to the Microsoft Copilot notice. SuggestionsNone. Risk assessment and necessityRisk: The regression surface is limited to Copilot capability privacy notice checks in CopilotCapabilityImpl.Codeunit.al and CopilotSettings.Table.al. Evaluation companies with no explicit approval may now see the Microsoft Copilot capability as inactive in the stricter case, while non-Copilot notices keep their previous evaluation-company behavior. No public API, event signature, posting logic, or persisted schema changed. Necessity: The change is needed so evaluation companies do not silently pass the Microsoft Copilot notice where the reported policy requires an explicit approval path. The implementation is small and matches the existing privacy notice extension point.
|
Fixes: AB#649638
Backport commit: d5ea8cc
Backports new behavior for chat v2 privacy policy to treat Eval companies as non-Eval companies