Skip to content

[28.5] Classify restored E-Document table sensitivities - #11276

Open
Milica Đukić (djukicmilica) wants to merge 1 commit into
microsoft:releases/28.5from
djukicmilica:bugs/648771-data-sensitivity-28.5
Open

[28.5] Classify restored E-Document table sensitivities#11276
Milica Đukić (djukicmilica) wants to merge 1 commit into
microsoft:releases/28.5from
djukicmilica:bugs/648771-data-sensitivity-28.5

Conversation

@djukicmilica

@djukicmilica Milica Đukić (djukicmilica) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Why

The restored E-Document lifecycle tables are not registered when demo data sensitivity evaluation runs. As a result, TestDataSensitivities fails because fields in table 6433 remain unclassified, starting with the Amount field.

Summary

  • Classified E-Document Message fields as normal sensitivity data.
  • Classified E-Doc. External Reference and E-Doc. Payment Occurrence fields as normal sensitivity data.
  • Prevented the W1 demo data sensitivity test from leaving restored E-Document tables unclassified.

Fixes
AB#649683

@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Team: Integrations GitHub request for Integrations area labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change adds E-Doc. External Reference and E-Doc. Payment Occurrence to the existing E-Document data-sensitivity evaluation registration. That makes the evaluation create Normal sensitivity rows for CustomerContent fields on those tables, in the same pattern as the other E-Document tables.

The added calls are in the existing ClassifyDataSensitivity subscriber. The event is raised after standard table-normal classification and before country-specific classification, so app table classifications are applied at the intended point. The changed table names exist on the PR head, and E-Document Message was already covered, so the diff addresses the unclassified lifecycle-table gap without changing runtime document behavior.

Problem-solution fit

Fit: Strong

The reported problem is unclassified restored E-Document lifecycle table fields during demo data sensitivity evaluation. The diff registers the missing restored tables that contain CustomerContent fields, including table 6433, and leaves the existing message-table registration in place.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: Low. The change is limited to the data-sensitivity evaluation subscriber for E-Document tables. It updates evaluation metadata only; it does not change posting, ledger entries, document processing, public APIs, event signatures, or upgrade data.

Necessity: The change is needed because restored E-Document lifecycle tables have CustomerContent fields and would otherwise remain Unclassified during evaluation, including the payment occurrence Amount field. The scope matches the affected tables and uses the existing classification pattern.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11276 round=1 by=alexei-dobriansky at=2026-09-09T22:25:15.6853620Z lastSha=71977979422cee92bdb62f697e1cbffb34c1ce1d reviewKey=e7fd30395e6c729c2585f8978ca7ae04be5a679dfc4323f8688aa29a43e50362 suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADO: Sync Creates an Azure DevOps work item if needed and indicates that one is linked AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants