Bug 649654: [29.0][NAV] Track Translation update (AUTODETECTED) - #11279
Conversation
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis change stops old DemoTool currency creation from explicitly validating the Symbol field after the currency code has already populated it. That avoids a notification-only General Ledger Setup lookup during early translated company setup, before that setup record exists. The fix matches the failing path: Code validation still assigns the resolved symbol directly, so the inserted currencies keep their symbols, but the later Symbol OnValidate trigger no longer blocks package generation. The same redundant validation is removed from every Create Currency layer, including the layer that failed and the parallel country layers. Problem-solution fitFit: Strong The reported failure is caused by validating the currency symbol while setup data is still incomplete. Removing that redundant validation addresses the failing setup phase without changing currency rounding, exchange rates, or the later local-currency setup update. SuggestionsNone. Risk assessment and necessityRisk: The risk is low and limited to demo-data currency creation. The change bypasses Symbol OnValidate notifications in src/Layers/*/DemoTool/CreateCurrency.Codeunit.al, but those checks only send duplicate/LCY symbol notifications and are not useful during automated package generation. Necessity: The change is needed because the translated demo-data build can fail before it creates the RapidStart package. The scope is appropriate because every layer with the same DemoTool currency insertion pattern is updated consistently.
|
586cc28
into
releases/29.0
Remove validation that causes failures if GLSetup isn't inserted yet. (translation builds)
Fixes AB#649654