Skip to content

Bug 649654: [29.0][NAV] Track Translation update (AUTODETECTED) - #11279

Merged
Bardur Knudsen (BardurKnudsen) merged 2 commits into
releases/29.0from
bugs/649654-curr
Sep 9, 2026
Merged

Bug 649654: [29.0][NAV] Track Translation update (AUTODETECTED)#11279
Bardur Knudsen (BardurKnudsen) merged 2 commits into
releases/29.0from
bugs/649654-curr

Conversation

@BardurKnudsen

@BardurKnudsen Bardur Knudsen (BardurKnudsen) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Remove validation that causes failures if GLSetup isn't inserted yet. (translation builds)

Fixes AB#649654

@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 9, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change stops old DemoTool currency creation from explicitly validating the Symbol field after the currency code has already populated it. That avoids a notification-only General Ledger Setup lookup during early translated company setup, before that setup record exists.

The fix matches the failing path: Code validation still assigns the resolved symbol directly, so the inserted currencies keep their symbols, but the later Symbol OnValidate trigger no longer blocks package generation. The same redundant validation is removed from every Create Currency layer, including the layer that failed and the parallel country layers.

Problem-solution fit

Fit: Strong

The reported failure is caused by validating the currency symbol while setup data is still incomplete. Removing that redundant validation addresses the failing setup phase without changing currency rounding, exchange rates, or the later local-currency setup update.

Suggestions

None.

Risk assessment and necessity

Risk: The risk is low and limited to demo-data currency creation. The change bypasses Symbol OnValidate notifications in src/Layers/*/DemoTool/CreateCurrency.Codeunit.al, but those checks only send duplicate/LCY symbol notifications and are not useful during automated package generation.

Necessity: The change is needed because the translated demo-data build can fail before it creates the RapidStart package. The scope is appropriate because every layer with the same DemoTool currency insertion pattern is updated consistently.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11279 round=1 by=alexei-dobriansky at=2026-09-09T19:14:03Z lastSha=44f8506d995c30d76e889cbcd181c3787dc58205 reviewKey=3f3c029213eb512b7e712de0e8c587c3ee4007c979e4d3b9f7c035f30dc76a09 suggestions=

@BardurKnudsen
Bardur Knudsen (BardurKnudsen) merged commit 586cc28 into releases/29.0 Sep 9, 2026
173 checks passed
@BardurKnudsen
Bardur Knudsen (BardurKnudsen) deleted the bugs/649654-curr branch September 9, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants