Skip to content

Bump react-film so webpack 5 apps on React 19 can bundle Web Chat - #5980

Merged
Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-react-film-react-19
Oct 29, 2026
Merged

Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-react-film-react-19

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

webpack 5 cannot bundle Web Chat with React 19: react-film 4.0.0 imports render from react-dom.

Changelog Entry

Changed

Description

React 19 removed render, and webpack 5 fails on the missing export. react-film's main build reads it inside its retrofit() only (spyip/react-film#110), which Web Chat does not call.

Design

Specific Changes

  • component/package.json: react-film@4.0.1-main.202610290630.8324311, pinned to main

  • package-lock.json: only react-film

  • I have added tests and executed them locally

  • I have added .changelog/<PR#>-<slug>.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Eugene Olonov added 2 commits October 29, 2026 00:09
… React 19

react-film 4.0.0 imports render() from react-dom, which React 19 removed; webpack 5 fails on the missing export. 4.0.1 reads it from the default export inside retrofit() only. Pinned to the main dist-tag until 4.0.1 is released.
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 29, 2026 07:27
Copilot AI balanced review requested due to automatic review settings October 29, 2026 07:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@OEvgeny
Eugene (OEvgeny) merged commit 5cac461 into main Oct 29, 2026
33 checks passed
@OEvgeny
Eugene (OEvgeny) deleted the OEvgeny/fix-react-film-react-19 branch October 29, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants