Fix 599 (Ubuntu 26.04 compat) by statically linking libxml2.so - #605
Open
Patrick Nelson (plnelson) wants to merge 2 commits into
Open
Fix 599 (Ubuntu 26.04 compat) by statically linking libxml2.so#605Patrick Nelson (plnelson) wants to merge 2 commits into
Patrick Nelson (plnelson) wants to merge 2 commits into
Conversation
Member
Author
Andrew Wang (WardenGnaw)
approved these changes
Aug 19, 2026
|
|
||
| if(CMAKE_SYSTEM_NAME STREQUAL Linux) | ||
| target_link_options(LibXml2 INTERFACE | ||
| "LINKER:--exclude-libs,libxml2.a" |
There was a problem hiding this comment.
I don't entirely understand this exclusion
|
|
||
| FetchContent_Declare( | ||
| libxml2 | ||
| URL https://download.gnome.org/sources/libxml2/2.15/libxml2-2.15.3.tar.xz |
There was a problem hiding this comment.
Will this be a netiso issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix compatibility with Ubuntu 26.04 by statically linking 26.04
This fixes 26.04 support while maintaining compatibility with older versions
Change Log
Test Methodology
Verify build and Nagler on both Ubuntu 24.04 and 26.04