[SM6.10] LinAlg: Update MatrixAccumulateToMemory to match spec#8658
Open
V-FEXrt wants to merge 1 commit into
Open
[SM6.10] LinAlg: Update MatrixAccumulateToMemory to match spec#8658V-FEXrt wants to merge 1 commit into
V-FEXrt wants to merge 1 commit into
Conversation
V-FEXrt
commented
Jul 22, 2026
| MatrixLayoutEnum Layout) { | ||
| __builtin_LinAlg_MatrixAccumulateToMemory(__handle, Arr, StartIdx, Stride, | ||
| Layout); | ||
| __builtin_LinAlg_MatrixAccumulateToMemory(__handle, Arr, 0, StartIdx, |
Collaborator
Author
There was a problem hiding this comment.
This shouldn't be hard coded to zero but there are a number of header changes required from the same spec PR. Instead of trying to pull the min set from the header changes to get this working I want to take the whole set as a separate PR (would have been too big a PR to include them here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new parameter to MatrixAccumulateToMemory as specified in microsoft/hlsl-specs#879
Fixes #8637