Skip to content

[HLSL] Correct ShaderOp SRV resource states #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JoeCitizen wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

[HLSL] Correct ShaderOp SRV resource states #8665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,9 +860,10 @@ void addSRVBuffer(st::ShaderOp *Op, const char *Name, UINT64 Width,
Res.Desc.MipLevels = 1;
Res.Desc.SampleDesc.Count = 1;
Res.Desc.Layout = D3D12_TEXTURE_LAYOUT_ROW_MAJOR;
Res.Desc.Flags = D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS;
Res.Desc.Flags = D3D12_RESOURCE_FLAG_NONE;
Res.InitialResourceState = D3D12_RESOURCE_STATE_COPY_DEST;
Res.TransitionTo = D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE;
Res.TransitionTo = D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE |
D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE;

Op->Resources.push_back(Res);
}
Expand Down
3 changes: 2 additions & 1 deletion tools/clang/unittests/HLSLExec/ShaderOpTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,8 @@ void ShaderOpTest::CreatePipelineState() {

void ShaderOpTest::CreateResources() {
CommandListRefs ResCommandList;
ResCommandList.CreateForDevice(m_pDevice, true);
// Graphics-only transition states require a DIRECT list.
ResCommandList.CreateForDevice(m_pDevice, /*compute*/ false);
ResCommandList.Allocator->SetName(
L"ShaderOpTest Resource Creation Allocation");
ResCommandList.Queue->SetName(L"ShaderOpTest Resource Creation Queue");
Expand Down
Loading