Integrate "get model versions" and "download specific model version" into cpp Core with max_versions by selenayang888 · Pull Request #816 · microsoft/Foundry-Local

selenayang888 · 2026-06-18T01:25:48Z

Porting the changes "get model versions" and "download specific model version" from C# into C++ Core now:

List all available versions of a model (e.g., to see what versions of phi-4 are published).
Download and use a specific older version (e.g., for reproducibility, compatibility, or regression testing).

…parsing

…o baijumeswani/catalog

…/integrate-get-model-versions-into-cpp

…odel-versions-into-cpp

vercel · 2026-06-18T01:25:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
foundry-local	Ready	Preview, Comment	Jun 18, 2026 1:25am

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

skottmckay · 2026-06-18T04:06:39Z

+  /// @param model_alias Alias of the model (e.g. "phi-4-mini"). May be NULL to return
+  ///        all versions of all models (subject to device/EP filtering).


Is there a use-case where someone needs to find all versions of all models? That seems like a problematic thing to enable given how much data could be retrieved.

If we require the alias I assume we have no need to expose pagination which is adding a lot of complexity to the code.

If a user really really needs to get all versions for all models they can iterate each alias themselves.

If we can remove the complexity from public pagination the implementation for fetching all versions of an alias or model name should be pretty similar to AzureCatalogClient::FetchModelsByIds, just with a slightly different filter.

Foundry-Local/sdk_v2/cpp/src/catalog/azure_catalog_client.cc

Lines 373 to 385 in 01939b1

std::vector<ModelInfo> AzureCatalogClient::FetchModelsByIds(

const std::vector<std::string>& model_ids) {

if (model_ids.empty()) {

return {};

}

auto result = FetchFilterSet(BuildModelIdFilters(model_filter_, model_ids));

if (!result) {

return {};

}

return ToModelInfos(result->models, result->region);

}

skottmckay · 2026-06-18T04:08:06Z

+  /// @param max_versions Soft upper bound on the number of variants returned.
+  ///        Pass 0 (or any negative value) for no cap.


Is the max on the versions or the variants? This feels like a really confusing value as I can think of various permutations between version and variant.

e.g. say I have model A with CPU (v1, 2, 3) and GPU variants (v 2, 3, 4).

'latest 2 versions' could be anything that is v3 or v4 (per alias), or it could be v2 and v3 for CPU and v3 and v4 for GPU (per variant).

I'm not sure which is best though. If versioning tends to be per variant, selecting the latest X for the variant might make more sense.

skottmckay · 2026-06-18T04:11:21Z

+  /// Returned list contains existing flModel handles owned by the catalog; releasing
+  /// the list does not invalidate the underlying model handles.
+  FL_API_STATUS(GetModelVersions, _In_ const flCatalog* catalog, _In_opt_ const char* model_alias,
+                _In_opt_ const char* variant_name, int32_t max_versions,


nit: would 'model_name' be more consistent given this value comes from Info_GetName (ModelInfo.Name) doesn't it?

skottmckay · 2026-06-18T04:13:35Z

+/// `annotations/tags/alias` filter scopes the result to that one alias; when
+/// empty, no alias filter is added and every versioned model the local hardware
+/// can run is returned across all its versions.
+std::vector<std::vector<CatalogFilter>> BuildAllVersionsFilters(const IEpDetector& ep_detector,


Can we add a param to BuildSearchFilters for 'all versions' or 'latest only' and linclude the 'labels' filter based on that instead of duplicating the logic here?

That said, shouldn't the model name be passed in here and used in the filter if provided so all filtering is server side?

skottmckay · 2026-06-18T04:24:16Z

  return created1 > created2;
 }

+int CompareCaseInsensitive(const std::string& lhs, const std::string& rhs) {


nit: might be good to put this in utils/string_utils.h

skottmckay · 2026-06-18T04:25:10Z

+  /// Provided with a default `{}` body so an implementation that has not yet
+  /// overridden it still compiles.
+  virtual PagedModelInfos FetchAllVersionsByAlias(
+      const std::string& /*model_alias*/,


Would have expected the model name to be passed in here if it can be used in the filter.

skottmckay · 2026-06-18T07:13:29Z

-      // Subsequent pages are pinned to the region that served page 1 — a filter set
-      // never mixes regions (continuation tokens are region-specific).
      response = http_post_response_(BuildRegionalUrl(url_prefix_, url_suffix_, *pinned_region), body);


AI likes randomly deleting existing comment. Was it intentional to do so?

baijumeswani and others added 14 commits June 11, 2026 21:20

Enable live catalog with region-aware fallback engine

3a6155b

Add AzureAiStudio User-Agent

cc1e22f

Address pr review comments

a827ec8

integrate get model versions into cpp core

a75bb36

Default registry region to centralus, httprequestoptions, and config …

fd865f3

…parsing

Merge branch 'main' of https://github.com/microsoft/Foundry-Local int…

c872980

…o baijumeswani/catalog

Address pull-request review comments

22f5b0f

Address pull-request review comments

d4b61f3

add max_version and continuation token

6739874

Change all defaults to centralus

f0fb73c

Address pull-request review comments

859d927

add a new test with empty alias and sort the results

7a3d089

Merge remote-tracking branch 'origin/baijumeswani/catalog' into syang…

b73c5e1

…/integrate-get-model-versions-into-cpp

Merge remote-tracking branch 'origin/main' into syang/integrate-get-m…

e7802c7

…odel-versions-into-cpp

selenayang888 marked this pull request as ready for review June 18, 2026 01:27

Copilot AI review requested due to automatic review settings June 18, 2026 01:27

Copilot started reviewing on behalf of selenayang888 June 18, 2026 01:29 View session

Copilot AI reviewed Jun 18, 2026

Copilot stopped reviewing on behalf of selenayang888 due to an error June 18, 2026 01:49
Copilot had to stop work due to a timeout.

skottmckay reviewed Jun 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate "get model versions" and "download specific model version" into cpp Core with max_versions#816

Integrate "get model versions" and "download specific model version" into cpp Core with max_versions#816
selenayang888 wants to merge 14 commits into
mainfrom
syang/integrate-get-model-versions-into-cpp

selenayang888 commented Jun 18, 2026

Uh oh!

vercel Bot commented Jun 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

skottmckay Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		/// @param model_alias Alias of the model (e.g. "phi-4-mini"). May be NULL to return
		/// all versions of all models (subject to device/EP filtering).

	std::vector<ModelInfo> AzureCatalogClient::FetchModelsByIds(
	const std::vector<std::string>& model_ids) {
	if (model_ids.empty()) {
	return {};
	}

	auto result = FetchFilterSet(BuildModelIdFilters(model_filter_, model_ids));
	if (!result) {
	return {};
	}

	return ToModelInfos(result->models, result->region);
	}

		/// @param max_versions Soft upper bound on the number of variants returned.
		/// Pass 0 (or any negative value) for no cap.

Conversation

selenayang888 commented Jun 18, 2026

Uh oh!

vercel Bot commented Jun 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants