FIX: distinguish catalog-unavailable from unregistered in Initializers page - #2464
Open
fei (feiiiiii5) wants to merge 1 commit into
Open
FIX: distinguish catalog-unavailable from unregistered in Initializers page#2464fei (feiiiiii5) wants to merge 1 commit into
fei (feiiiiii5) wants to merge 1 commit into
Conversation
…s page When the registered-initializer catalog request fails transiently, the Initializers page preserved configured baseline settings but described valid entries as 'Initializer is no longer registered.' A temporary metadata availability failure was therefore presented as a definitive registration problem. Track catalog fetch success/failure and pass the availability flag through to BaselineInitializers / AdditionalInitializers so unresolved names render 'Catalog metadata temporarily unavailable.' when only the catalog request failed. Names genuinely absent from a successful catalog response still show 'no longer registered.' Fixes microsoft#2442 Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2442
When
/api/initializers/settingssucceeds but the registered-initializer catalog request (GET /api/initializers) fails transiently, the Initializers page preserved configured baseline settings but described valid entries asInitializer is no longer registered.A temporary metadata availability failure was therefore presented as a definitive registration problem.Changes:
Initializers.tsx: trackcatalogUnavailablestate — set totruewhen only the catalog request rejects, reset on success or refreshBaselineInitializers.tsx/AdditionalInitializers.tsx: accept and forward the flaginitializerLookup.ts: when the catalog is unavailable, unresolved names renderCatalog metadata temporarily unavailable.instead of the definitive fallback; names genuinely absent from a successful response still showno longer registeredTests and Documentation
initializerLookup.test.ts:catalogUnavailable=truetsc --noEmit(0 errors)This contribution was developed with LLM assistance following repo conventions.