FIX: report initializer catalog outages as unavailable, not unregistered - #2469
Open
fei (feiiiiii5) wants to merge 1 commit into
Open
FIX: report initializer catalog outages as unavailable, not unregistered#2469fei (feiiiiii5) wants to merge 1 commit into
fei (feiiiiii5) wants to merge 1 commit into
Conversation
…red (microsoft#2442) When GET /api/initializers (the registered catalog) fails while /api/initializers/settings succeeds, configured rows previously rendered with 'Initializer is no longer registered.' — presenting a temporary metadata outage as a definitive configuration problem. resolveRegisteredInitializer now takes a catalogAvailable flag: when the catalog could not be loaded, rows get an 'UnverifiedInitializer' placeholder whose copy says the catalog is temporarily unavailable and that registration state cannot be confirmed. A row is only described as no longer registered when a successful catalog response actually lacks the name. Initializers tracks catalog availability across refreshes and threads it through BaselineInitializers / AdditionalInitializers. Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #2442.
When
/api/initializers/settingssucceeds but the registered-Initializer catalog request transiently fails, the Initializers page kept the configured rows but described valid entries asInitializer is no longer registered.— presenting a temporary metadata availability failure as a definitive registration/configuration problem.What changed
resolveRegisteredInitializergains acatalogAvailableflag (defaulttrue, so existing call sites are unaffected). When the catalog could not be loaded, rows get anUnverifiedInitializerplaceholder whose copy says the catalog is temporarily unavailable and that registration state cannot be confirmed. The "no longer registered" claim is now only made when a successful catalog response actually lacks the name.Initializers.tsxtracks catalog availability across loads and refreshes and threads it throughBaselineInitializers/AdditionalInitializers.Validation
initializerLookup.test.ts): catalog-unavailable copy never contains "no longer registered"; available-catalog unknown names still produce the unregistered placeholder.Initializers.test.tsx): with settings succeeding and the catalog returning 5xx, the baseline row shows "temporarily unavailable" copy, does not show "no longer registered", and a Refresh after the catalog recovers restores the real description ("Registers targets.").tsc --noEmitclean; ESLint clean on all touched files.AI usage disclosure