Skip to content

TEST: avoid cancelling scenario resume for slow database reads #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richard Lundeen (richlundeen) wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

TEST: avoid cancelling scenario resume for slow database reads #3138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/unit/scenario/core/test_scenario_partial_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,12 +1004,16 @@ async def mock_run(*args, **kwargs):
assert len(result.attack_results["attack_2"]) == 3
assert len(result.attack_results["attack_3"]) == 1

async def test_concurrent_partial_failures_resume_without_duplicate_results(self, mock_objective_target):
@pytest.mark.timeout(60)
async def test_concurrent_partial_failures_resume_without_duplicate_results(
self, *, mock_objective_target: MagicMock
) -> None:
"""
Concurrent partial failures should surface together and resume only unfinished objectives.

Three attacks start together. Two persist one result each before failing, while the
third succeeds. A second run must execute only the two unfinished objectives.
The test watchdog bounds deadlocks without cancelling slow database reads within a run.
"""
attack_a = create_mock_atomic_attack("attack-a", ["a-complete", "a-retry"])
attack_b = create_mock_atomic_attack("attack-b", ["b-complete", "b-retry"])
Expand Down Expand Up @@ -1098,7 +1102,7 @@ async def run_attack_c_async(*args, **kwargs) -> AttackExecutorResult[AttackResu
wraps=scenario._memory.update_scenario_run_state_async,
) as update_state:
with pytest.raises(ExceptionGroup) as exc_info:
await asyncio.wait_for(scenario.run_async(), timeout=10)
await scenario.run_async()

assert all(isinstance(error, ScenarioPartialFailureException) for error in exc_info.value.exceptions)
partial_failures = {
Expand All @@ -1116,7 +1120,7 @@ async def run_attack_c_async(*args, **kwargs) -> AttackExecutorResult[AttackResu
assert failed_result.scenario_run_state == ScenarioRunState.FAILED
assert failed_result.number_tries == 1

final_result = await asyncio.wait_for(scenario.run_async(), timeout=10)
final_result = await scenario.run_async()

assert final_result.scenario_run_state == ScenarioRunState.COMPLETED
assert final_result.number_tries == 2
Expand Down
Loading