P3059R2: Making user-defined constructors of view iterators/sentinels private. - #6382
Open
Iskandar Emomzoda (iskandarem) wants to merge 41 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 26, 2026 18:06
View session
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Work In Progress
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
added
cxx20
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 26, 2026 18:14
View session
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Iskandar Emomzoda (iskandarem)
marked this pull request as draft
July 26, 2026 18:50
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 27, 2026 08:52
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 27, 2026 09:02
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 27, 2026 11:55
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
July 27, 2026 12:39
View session
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
This comment was marked as resolved.
This comment was marked as resolved.
…o unable-view-sentinel-iterator-creation-from-outside
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
August 6, 2026 12:41
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
August 6, 2026 14:20
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
August 6, 2026 23:29
View session
A. Jiang (frederick-vs-ja)
referenced
this pull request
in llvm/llvm-project
Aug 7, 2026
…erators/sentinels private (#193891) Implements https://wg21.link/P3059R2 (DR) Closes #189599 1. Made constructors of iterator and sentinel types of the following views private: - `iota_view` - `basic_istream_view` - `filter_view` - `transform_view` - `take_view` - `take_while_view` - `join_view` - `lazy_split_view` - `split_view` - `elements_view` 2. Updated all relevant tests to fix the usages of the now private constructor, including: 1. Removed now obsolete tests (files and cases). 2. Updated all relevant tests to get the iterators and the sentinels via `begin()` and `end()`, wherever applicable . 3. Added test cases to confirm that P3059R2 was implemented properly. 4. Minor other (necessary) tweaks. --------- Co-authored-by: Hristo Hristov <zingam@outlook.com> Co-authored-by: A. Jiang <de34@live.cn>
…include _Iotinel as AlternativeType;
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
August 7, 2026 09:52
View session
Copilot started reviewing on behalf of
Iskandar Emomzoda (iskandarem)
August 13, 2026 11:53
View session
Stephan T. Lavavej (StephanTLavavej)
moved this from Work In Progress
to Initial Review
in STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User defined constructors for following view-iterators/sentinels made private:
Removed the
_Iotineland replaced it with a nestediota_view::_Sentinel. This avoids changing the ABI of the existing_Ioineltype while making the implementation closer to the Standard wording.closes #6241