Skip to content

Test: Remove broken TEST_EVERYTHING branch from P0896R4_views_elements - #6415

Open
zika (tycket033-tech) wants to merge 1 commit into
microsoft:mainfrom
tycket033-tech:codex/issue-6237-remove-broken-test-everything
Open

Test: Remove broken TEST_EVERYTHING branch from P0896R4_views_elements#6415
zika (tycket033-tech) wants to merge 1 commit into
microsoft:mainfrom
tycket033-tech:codex/issue-6237-remove-broken-test-everything

Conversation

@tycket033-tech

Copy link
Copy Markdown

Fixes #6237.

This removes the TEST_EVERYTHING branch from P0896R4_views_elements.

That branch tries to instantiate proxy-reference ranges, but those references aren't tuple-like and can't satisfy elements_view's constraints. The existing explicit matrix already covers the relevant non-proxy combinations, so it now runs regardless of whether TEST_EVERYTHING is defined.

Validation:

  • Built and ran P0896R4_views_elements normally with /W4 /WX.
  • Built and ran it again with /DTEST_EVERYTHING /W4 /WX.
  • Both configurations passed.

AI disclosure: OpenAI Codex with GPT-5.6 Sol was used to inspect the issue and apply this four-line test-only deletion. I reviewed the final diff and test results before submission.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added test Related to test code ranges C++20/23 ranges labels Aug 24, 2026
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) marked this pull request as ready for review August 24, 2026 14:41
Copilot AI balanced review requested due to automatic review settings August 24, 2026 14:42
@azure-pipelines

This comment was marked as resolved.

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks. This PR should have been created normally, instead of in draft status (which for us, doesn't run checks; not that it makes a difference for first-time contributor PRs which can't automatically run checks).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an invalid TEST_EVERYTHING path while preserving the valid non-proxy elements_view test matrix.

Changes:

  • Always runs the explicit non-proxy range permutations.
  • Prevents unsupported proxy-reference instantiations.
Show a summary per file
File Description
tests/std/tests/P0896R4_views_elements/test.cpp Removes the broken conditional test branch.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@tycket033-tech

Copy link
Copy Markdown
Author

Thanks. This PR should have been created normally, instead of in draft status (which for us, doesn't run checks; not that it makes a difference for first-time contributor PRs which can't automatically run checks).

Thanks for the clarification. I'll open future PRs as ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ranges C++20/23 ranges test Related to test code

Projects

Status: Initial Review

Development

Successfully merging this pull request may close these issues.

P0896R4_views_elements: The test isn't compatible with TEST_EVERYTHING

3 participants