Test: Remove broken TEST_EVERYTHING branch from P0896R4_views_elements - #6415
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks. This PR should have been created normally, instead of in draft status (which for us, doesn't run checks; not that it makes a difference for first-time contributor PRs which can't automatically run checks). |
There was a problem hiding this comment.
Pull request overview
Removes an invalid TEST_EVERYTHING path while preserving the valid non-proxy elements_view test matrix.
Changes:
- Always runs the explicit non-proxy range permutations.
- Prevents unsupported proxy-reference instantiations.
Show a summary per file
| File | Description |
|---|---|
tests/std/tests/P0896R4_views_elements/test.cpp |
Removes the broken conditional test branch. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Thanks for the clarification. I'll open future PRs as ready for review. |
Fixes #6237.
This removes the
TEST_EVERYTHINGbranch fromP0896R4_views_elements.That branch tries to instantiate proxy-reference ranges, but those references aren't tuple-like and can't satisfy
elements_view's constraints. The existing explicit matrix already covers the relevant non-proxy combinations, so it now runs regardless of whetherTEST_EVERYTHINGis defined.Validation:
P0896R4_views_elementsnormally with/W4 /WX./DTEST_EVERYTHING /W4 /WX.AI disclosure: OpenAI Codex with GPT-5.6 Sol was used to inspect the issue and apply this four-line test-only deletion. I reviewed the final diff and test results before submission.